Review main Merged

25914[BUGFIX] Exception in FileMetadataOverlayAspect

Georg Ringer CR +2 V +2 Easy +3 −2 updated 01/14/14, 10:08

Commit message

It is possible that PageRepository::getRecordOverlay() returns NULL which
throws an exception as ArrayObject::exchangeArray() either needs an
array or an (array-)object.

The fix adds a small check for the Result of the PageRepository function.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Oliver Klee +1
    • Steffen Ritter +1
    • Frans Saris +1
  • Verified V +2
    • Georg Ringer +2
    • Frans Saris +1

Issues 1

Files 1

Review log 14

  1. Mr. Jenkins commented on patch set 1 12/03/13, 15:01

  2. Frans Saris commented on patch set 1 12/04/13, 20:03

    FileMetadataOverlayAspect.php:56

    Why not use !== NULL
  3. Wouter Wolters uploaded patch set 2 12/07/13, 13:58

  4. Wouter Wolters voted on patch set 2 CR +1 12/07/13, 13:59

  5. Mr. Jenkins commented on patch set 2 12/07/13, 14:12

  6. Steffen Ritter updated the commit message in patch set 2 12/08/13, 09:19

  7. Steffen Ritter voted on patch set 3 CR +1 12/08/13, 09:20

  8. Mr. Jenkins commented on patch set 3 12/08/13, 09:32

  9. Oliver Klee voted on patch set 3 CR +1 12/08/13, 12:02

  10. Frans Saris commented on patch set 3 12/18/13, 17:40

    @georg, how can I test/trigger the exeption?
  11. Georg Ringer commented on patch set 3 01/14/14, 08:07

    apply https://review.typo3.org/#/c/25932/ and use some records which are not displayed in used language + strict language mode
  12. Frans Saris voted on patch set 3 V +1 CR +1 01/14/14, 09:49

  13. Georg Ringer voted on patch set 3 V +2 CR +2 01/14/14, 10:08

  14. Georg Ringer merged patch set 4 01/14/14, 10:08