Review main Merged

2593[BUGFIX] Cache toolbar items have incorrect width

Andreas Wolf CR +2 V +2 Easy +2 −2 updated 06/03/13, 20:49

Commit message

The items in the clear cache toolbar do not span the full width of the
menu. This is because a float:left; that was inserted for the top-level
items of the toolbar also affects these items.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Mario Rimann +1
    • Georg Ringer +1
    • Markus Klein +1
    • Philipp Gampe +1
  • Verified V +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Mario Rimann +1
    • Georg Ringer +1

Issues 1

Files 2

Review log 8

  1. Mario Rimann commented on patch set 1 06/19/11, 19:59

    Verified; Looks good to me, but someone else must approve Verified on WinXP in the following browsers: Safari 5.0.5 Firefox 4.0.1 Internet Explorer 8 (current version with a way tooo long version number) Chrome (current version with a way tooo long version number)
  2. Stefan Neufeind commented on patch set 1 06/19/11, 19:59

    Verified; Looks good to me, but someone else must approve
  3. Markus Klein commented on patch set 1 06/19/11, 19:59

    Looks good to me, but someone else must approve
  4. Christian Kuhn commented on patch set 1 V 0 06/19/11, 19:59

    by team member; Looks good to me, approved
  5. Georg Ringer commented on patch set 1 06/19/11, 19:59

    Verified; Looks good to me, but someone else must approve
  6. Philipp Gampe commented on patch set 1 06/19/11, 19:59

    Looks good to me, but someone else must approve
  7. Mr. Jenkins commented on patch set 1 06/19/11, 19:59

  8. Christian Kuhn merged patch set 1 06/19/11, 19:59