Review main Merged

25932[BUGFIX] Usage of sys_lang_mode in Typo3DbBackend

Georg Ringer CR +2 V +2 Easy +1 −1 updated 01/14/14, 08:08

Commit message

Due refactoring the property $languageMode is compared but is never
filled. The property from the querySettings has to be used.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Markus Klein +1
  • Verified V +2
    • Georg Ringer +2

Issues 1

Files 1

Review log 14

  1. Mr. Jenkins commented on patch set 1 12/04/13, 06:05

  2. Markus Klein commented on patch set 1 12/04/13, 06:53

    nice one :-)
  3. Markus Klein updated the commit message in patch set 1 12/04/13, 06:54

  4. Markus Klein commented on patch set 2 V +1 CR +1 12/04/13, 06:54

    no-brainer
  5. Mr. Jenkins commented on patch set 2 12/04/13, 07:08

  6. Stefan Neufeind voted on patch set 2 CR +1 12/04/13, 23:57

  7. Xavier Perseguers commented on patch set 2 12/06/13, 21:24

    Typo3DbBackend.php:1181

    According to documentation, @return mixed TRUE, FALSE or "hideNonTranslated", we need $querySettings->getLanguageMode() here and this would fit the original variable name
  8. Markus Klein rebased onto patch set 2 01/09/14, 14:29

  9. Markus Klein uploaded patch set 4 01/09/14, 14:31

  10. Markus Klein voted on patch set 4 CR +1 01/09/14, 14:31

  11. Mr. Jenkins commented on patch set 3 01/09/14, 14:43

  12. Mr. Jenkins commented on patch set 4 01/09/14, 14:49

  13. Georg Ringer voted on patch set 4 V +2 CR +2 01/14/14, 08:08

  14. Georg Ringer merged patch set 5 01/14/14, 08:08