Review main Merged

2594[BUGFIX] Toolbar menus have no hover

Andreas Wolf CR +2 V +2 Easy +8 −1 updated 06/03/13, 20:49

Commit message

All toolbar menu items currently have no hover. This patch adds a hover
to tr and li classes inside these menus.

Original patch by Steffen Kamper.

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Stefan Neufeind +1
    • Georg Ringer +1
    • Kay Strobach +1
  • Verified V +2
    • Andreas Wolf +2
    • Stefan Neufeind +1
    • Georg Ringer +1
    • Kay Strobach +1

Issues 1

Files 1

Review log 12

  1. Andreas Wolf uploaded patch set 2 06/12/11, 16:13

  2. Andreas Wolf commented on patch set 2 06/12/11, 16:13

    Georg, you're right. Fixed that with this new commit. Another problem still exists: The hover does not affect the shadow inside some menus. But this problem is out of scope for this patch.
  3. Stefan Neufeind commented on patch set 2 06/12/11, 16:13

    Verified; Looks good to me, but someone else must approve Andreas meant this is for inside the dropdown-menus, like in the "clear cache"-dropdown. Yes, that works perfect for me. :-)
  4. Stefan Neufeind commented on patch set 2 06/12/11, 16:13

    Can't seem to find the toolbar you refer to which needs this :-( But since others seem to have found and successfully reviewed it ...
  5. Georg Ringer commented on patch set 1 06/12/11, 16:13

    I would prefer that you didn't submit this IMO this belongs to visual/toolbar.css a and not structure/toolbar.css
  6. Georg Ringer commented on patch set 2 06/12/11, 16:13

    Verified; Looks good to me, but someone else must approve
  7. Kay Strobach commented on patch set 2 06/12/11, 16:13

    it's the top toolbar where the search and versioning/workspace/etc buttons reside ;) nearby the typo3 logo
  8. Kay Strobach commented on patch set 2 06/12/11, 16:13

    Verified; Looks good to me, but someone else must approve
  9. Mr. Jenkins commented on patch set 1 06/12/11, 16:13

  10. Mr. Jenkins commented on patch set 2 06/12/11, 16:13

  11. Andreas Wolf commented on patch set 2 V 0 06/12/11, 16:13

    by team member; Looks good to me, approved Pushing this after enough positive reviews. Hovers for the menu buttons themselves should be added, too.
  12. Andreas Wolf merged patch set 2 06/12/11, 16:13