2594[BUGFIX] Toolbar menus have no hover
Commit message
Review
-
Code review CR +2
- Andreas Wolf +2
- Stefan Neufeind +1
- Georg Ringer +1
- Kay Strobach +1
-
Verified V +2
- Andreas Wolf +2
- Stefan Neufeind +1
- Georg Ringer +1
- Kay Strobach +1
Issues 1
Files 1
Review log 12
-
Andreas Wolf uploaded patch set 2 06/12/11, 16:13
-
Andreas Wolf commented on patch set 2 06/12/11, 16:13
Georg, you're right. Fixed that with this new commit. Another problem still exists: The hover does not affect the shadow inside some menus. But this problem is out of scope for this patch. -
Stefan Neufeind commented on patch set 2 06/12/11, 16:13
Verified; Looks good to me, but someone else must approve Andreas meant this is for inside the dropdown-menus, like in the "clear cache"-dropdown. Yes, that works perfect for me. :-) -
Stefan Neufeind commented on patch set 2 06/12/11, 16:13
Can't seem to find the toolbar you refer to which needs this :-( But since others seem to have found and successfully reviewed it ... -
Georg Ringer commented on patch set 1 06/12/11, 16:13
I would prefer that you didn't submit this IMO this belongs to visual/toolbar.css a and not structure/toolbar.css -
Georg Ringer commented on patch set 2 06/12/11, 16:13
Verified; Looks good to me, but someone else must approve -
Kay Strobach commented on patch set 2 06/12/11, 16:13
it's the top toolbar where the search and versioning/workspace/etc buttons reside ;) nearby the typo3 logo -
Kay Strobach commented on patch set 2 06/12/11, 16:13
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 06/12/11, 16:13
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/671/ : SUCCESS -
Mr. Jenkins commented on patch set 2 06/12/11, 16:13
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/679/ : SUCCESS -
Andreas Wolf commented on patch set 2 V 0 06/12/11, 16:13
by team member; Looks good to me, approved Pushing this after enough positive reviews. Hovers for the menu buttons themselves should be added, too. -
Andreas Wolf merged patch set 2 06/12/11, 16:13