Review main Merged

26058[FEATURE] Fallback/default case for SwitchViewhelper

Anja Leichsenring CR +2 V +2 Normal +72 −5 updated 02/10/14, 21:31

Commit message

In order to provide the full functionality known from the
switch/case PHP function, a default case possibility is
introduced. Use it like:
<f:switch expression="{person.gender}">
  <f:case value="female">Mrs.</f:case>
  <f:case value="male">Mr.</f:case>
  <f:case default="TRUE">Mrs. or Mr.</f:case>
</f:switch>

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Benjamin Kott +1
  • Verified V +2
    • Anja Leichsenring +2
    • Benjamin Kott +1

Issues 1

Files 3

Review log 6

  1. Anja Leichsenring commented on patch set 1 V +1 CR +1 12/08/13, 15:32

    ready to merge, but not after feature freeze.
  2. Mr. Jenkins commented on patch set 1 12/08/13, 15:46

  3. Ernesto Baschny commented on patch set 1 02/10/14, 13:06

    I agree to allow including this improvement into 6.2 even after feature freeze, to make the newly introduced Switch (http://forge.typo3.org/issues/48653) ViewHelper complete in the LTS release. See also https://review.typo3.org/#/c/23739/ (which was reverted in December).
  4. Benjamin Kott voted on patch set 1 V +1 CR +1 02/10/14, 14:14

  5. Anja Leichsenring commented on patch set 1 V +2 CR +2 02/10/14, 21:31

    Thanks Ernesto for the exception.
  6. Anja Leichsenring merged patch set 2 02/10/14, 21:31