Review main Merged

26094[TASK] oncontextmenu: Avoid duplicating onclick-functionality

Stefan Neufeind CR +2 V +2 Easy +5 −6 updated 12/18/13, 22:30

Commit message

Where onclick and oncontextmenu behave the same avoid duplicating
JavaScript-code and simply call the click()-functionality.

Review

  • Code review CR +2
    • Markus Klein +2
    • Frans Saris +1
  • Verified V +2
    • Markus Klein +2
    • Frans Saris +1

Issues 1

Files 5

Review log 7

  1. Mr. Jenkins commented on patch set 1 12/09/13, 00:42

  2. Markus Klein voted on patch set 1 CR +1 12/09/13, 10:13

  3. Stefan Neufeind commented on patch set 1 12/18/13, 11:46

    Not a big change imho but avoids some duplication (and shrinks HTML-output quite a bit in some cases). Looking forward to your reviews and verifies.
  4. Markus Klein voted on patch set 1 V +1 12/18/13, 12:54

  5. Frans Saris voted on patch set 1 V +1 CR +1 12/18/13, 22:18

  6. Markus Klein voted on patch set 1 V +2 CR +2 12/18/13, 22:30

  7. Markus Klein merged patch set 2 12/18/13, 22:30