Review main Merged

2610[BUGFIX] Remove hardcoded limits in T3D export

Georg Ringer CR +2 V +2 Easy +0 −8 updated 06/03/13, 20:49

Commit message

The memory_limit is hardcoded to 256m and
max_execution_time to 600.

There is no reason to hardcode those settings,
sometimes a bit more of both is needed.

Review

  • Code review CR +2
    • Steffen Gebert +2
    • Stefan Neufeind +1
    • Björn Pedersen +1
    • Kay Strobach +1
  • Verified V +2
    • Steffen Gebert +2
    • Stefan Neufeind +1
    • Kay Strobach +1

Issues 4

Files 1

Review log 13

  1. Mario Rimann commented on patch set 1 07/19/11, 19:29

    Looks good to me, but someone else must approve
  2. Stefan Neufeind commented on patch set 1 07/19/11, 19:29

    Verified; Looks good to me, but someone else must approve Stumbled across this myself lately. Amazing why they were in there for such a long time :-)
  3. Stefan Neufeind commented on patch set 1 07/19/11, 19:29

    Please also consider adding other bugs in the Resolves-line, namely #18926, #17020 and possibly related ones.
  4. Björn Pedersen commented on patch set 2 07/19/11, 19:29

    Looks good to me, but someone else must approve
  5. Stefan Neufeind uploaded patch set 2 07/19/11, 19:29

  6. Stefan Neufeind commented on patch set 2 07/19/11, 19:29

    Verified; Looks good to me, but someone else must approve Imho his already had enough votes. Added some more tickets that just removing the values (and relying on the php-config) solves. Affects 4.5 also. Would really appreciate this to go in since it has annoyed various people over time ...
  7. Georg Ringer commented on patch set 1 07/19/11, 19:29

    IMO a real nobrainer
  8. Steffen Gebert commented on patch set 2 V 0 07/19/11, 19:29

    by team member; Looks good to me, approved Georg, would you push this for 4.5, too?
  9. Kay Strobach commented on patch set 1 07/19/11, 19:29

    Verified; Looks good to me, but someone else must approve
  10. Kay Strobach commented on patch set 2 07/19/11, 19:29

    Verified; Looks good to me, but someone else must approve
  11. Mr. Jenkins commented on patch set 1 07/19/11, 19:29

  12. Mr. Jenkins commented on patch set 2 07/19/11, 19:29

  13. Steffen Gebert merged patch set 2 07/19/11, 19:29