Review main Merged

26278[BUGFIX] Clear statcache after writing file contents

Alexander Stehlik CR +2 V +2 Easy +4 −0 updated 12/11/13, 08:20

Commit message

To make sure calls to filesize() etc. return correct values the PHP
method clearstatcache() is called in the LocalDriver after contents
were written to a file.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Markus Klein +1
    • Frans Saris +1
  • Verified V +2
    • Georg Ringer +2

Issues 1

Files 1

Review log 9

  1. Markus Klein commented on patch set 1 CR +1 12/10/13, 14:44

    See my comment please. The docs for clearstatcache() specifically mentions that "if the same file is being checked multiple times within a single script, and that file is in danger of being removed or changed during that script's operation, you may elect to clear the status cache."

    LocalDriver.php:1248

    Maybe specify the path to the file to only clear the cache for that file?
  2. Mr. Jenkins commented on patch set 1 12/10/13, 14:50

  3. Alexander Stehlik commented on patch set 1 12/10/13, 14:50

    Good idea :)
  4. Alexander Stehlik uploaded patch set 2 12/10/13, 15:21

  5. Mr. Jenkins commented on patch set 2 12/10/13, 15:37

  6. Markus Klein voted on patch set 2 CR +1 12/10/13, 15:46

  7. Frans Saris voted on patch set 2 CR +1 12/11/13, 07:48

  8. Georg Ringer voted on patch set 2 V +2 CR +2 12/11/13, 08:20

  9. Georg Ringer merged patch set 3 12/11/13, 08:20