Review main Merged

2628[FEATURE] Move "Appearance" tab before "Access" tab

Soren Malling CR +2 V +2 Normal +43 −43 updated 06/03/13, 20:49

Commit message

The use of settings in the "Appearance" tab are most likely related to
setting in tabs placed before the "Access" tab.

The "Appearance" should be moved before the "Access" tab to give a
correct workflow

Review

  • Code review CR +2
    • Andreas Wolf +2
  • Verified V +2
    • Andreas Wolf +2

Issues 1

Files 1

Review log 10

  1. Andreas Wolf merged patch set 1 07/27/11, 07:31

    tbl_tt_content.php:1693

    Please use a tab here.
  2. Andreas Wolf commented on patch set 1 1 comment 07/27/11, 07:31

    Looks good to me, but someone else must approve Fine with me except for one remark.
  3. Stefan Neufeind commented on patch set 1 07/27/11, 07:31

    Looks good to me, but someone else must approve as Kay said, backport would be great
  4. Andreas Wolf commented on patch set 2 V 0 07/27/11, 07:31

    by team member; Looks good to me, approved
  5. Stefan Neufeind uploaded patch set 2 07/27/11, 07:31

  6. Stefan Neufeind commented on patch set 2 07/27/11, 07:31

    Just fixed the one tab mentioned. Other votes still apply (please re-vote).
  7. Kay Strobach commented on patch set 1 07/27/11, 07:31

    Verified; Looks good to me, but someone else must approve please backport this to 4.5 :)
  8. Mr. Jenkins commented on patch set 1 07/27/11, 07:31

  9. Mr. Jenkins commented on patch set 2 07/27/11, 07:31

  10. Oliver Hader commented on patch set 2 07/27/11, 07:31

    Post-review: Looks good to me