26339[BUGFIX] Use correct file data variable in Indexer
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Steffen Ritter +1
-
Verified V +2
- Markus Klein +2
- Steffen Ritter +1
Issues 1
Files 1
Review log 10
-
Mr. Jenkins commented on patch set 1 12/11/13, 07:27
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12556/ : SUCCESS -
Frans Saris voted on patch set 1 CR +1 12/11/13, 07:29
-
Frans Saris commented on patch set 1 CR -1 12/11/13, 07:39
Indexer.php:177$data === NULLIndexer.php:179This doesn't respect the current storageIndexer.php:185imo this is wrong to. does not do anything. Think this line can be left out. -
Steffen Ritter commented on patch set 1 12/12/13, 19:17
Hi Alex, thanks for the patch - good catch actually! There are two more things "broken" in that part. I would appreciate if you could update the patch, according to the comments; Please omit the out-of-scope CGL cleanup Frans asked for, if you provide a new patch set. Thanks in advance SteffenIndexer.php:177Replyout of scope! not part of this patchIndexer.php:179Replydoes not matterIndexer.php:185Reply=> $identifier is missing hereIndexer.php:187probably we need to checker if the storage changed and call another indexer... -
Alexander Stehlik uploaded patch set 2 12/14/13, 18:10
-
Alexander Stehlik commented on patch set 1 12/14/13, 18:13
I updated the patch as requested. Unfortunately i found two new issues while testing: #54414 and #54415. I guess Frans is right, that the storage should be respected when searching for the hash.Indexer.php:179ReplyI'm not so sure about this, please have a look at #54415Indexer.php:185ReplyDone -
Mr. Jenkins commented on patch set 2 12/14/13, 19:21
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12590/ : SUCCESS -
Steffen Ritter voted on patch set 2 V +1 CR +1 12/18/13, 14:45
-
Markus Klein voted on patch set 2 V +2 CR +2 12/18/13, 14:58
-
Markus Klein merged patch set 3 12/18/13, 14:58