Review main Merged

26339[BUGFIX] Use correct file data variable in Indexer

Alexander Stehlik CR +2 V +2 Easy +2 −2 updated 12/18/13, 14:58

Commit message

The processChangedAndNewFiles() method in the Indexer class now uses
the $fileIndexEntry variable for retrieving a file object from the
resource factory instead of the invalid $data variable which is NULL.

Review

  • Code review CR +2
    • Markus Klein +2
    • Steffen Ritter +1
  • Verified V +2
    • Markus Klein +2
    • Steffen Ritter +1

Issues 1

Files 1

Review log 10

  1. Mr. Jenkins commented on patch set 1 12/11/13, 07:27

  2. Frans Saris voted on patch set 1 CR +1 12/11/13, 07:29

  3. Frans Saris commented on patch set 1 CR -1 12/11/13, 07:39

    Indexer.php:177

    $data === NULL

    Indexer.php:179

    This doesn't respect the current storage

    Indexer.php:185

    imo this is wrong to. does not do anything. Think this line can be left out.
  4. Steffen Ritter commented on patch set 1 12/12/13, 19:17

    Hi Alex, thanks for the patch - good catch actually! There are two more things "broken" in that part. I would appreciate if you could update the patch, according to the comments; Please omit the out-of-scope CGL cleanup Frans asked for, if you provide a new patch set. Thanks in advance Steffen

    Indexer.php:177 Reply

    out of scope! not part of this patch

    Indexer.php:179 Reply

    does not matter

    Indexer.php:185 Reply

    => $identifier is missing here

    Indexer.php:187

    probably we need to checker if the storage changed and call another indexer...
  5. Alexander Stehlik uploaded patch set 2 12/14/13, 18:10

  6. Alexander Stehlik commented on patch set 1 12/14/13, 18:13

    I updated the patch as requested. Unfortunately i found two new issues while testing: #54414 and #54415. I guess Frans is right, that the storage should be respected when searching for the hash.

    Indexer.php:179 Reply

    I'm not so sure about this, please have a look at #54415

    Indexer.php:185 Reply

    Done
  7. Mr. Jenkins commented on patch set 2 12/14/13, 19:21

  8. Steffen Ritter voted on patch set 2 V +1 CR +1 12/18/13, 14:45

  9. Markus Klein voted on patch set 2 V +2 CR +2 12/18/13, 14:58

  10. Markus Klein merged patch set 3 12/18/13, 14:58