26445[BUGFIX] Add stdWrap on value property of TEXT
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Chris topher +1
- Benni Mack +1
-
Verified V +2
- Stefan Neufeind +2
- Chris topher +1
Issues 1
Files 1
Review log 18
-
Mr. Jenkins commented on patch set 1 12/16/13, 09:57
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12594/ : SUCCESS -
Dmitry Dulepov commented on patch set 1 12/16/13, 12:29
TEXT is itself a stdWrap, so I do not really see any value in this :( Example: 10 = TEXT 10.value = world 10.value.noTrimWrap = |Hello, |!| and 10 = TEXT 10.value = world 10.noTrimWrap = |Hello, |!| Those are equivalent. What's the point? -
Markus Klein commented on patch set 1 12/16/13, 15:03
@Dmitry: I fully agree with you, but as described in the forge ticket, the documentation mentions stdWrap on value since 6.0 and the conclusion in the mailing list discussion was that it has been forgotten to add to the value property. Motto was "stdWrap for everything". Since it doesn't hurt here, I'd just add it and the user can choose where he wants to apply the stdWrap settings. -
Chris topher commented on patch set 1 12/16/13, 15:18
Hi Markus, thanks for pushing this one! Markus is right; having stdWrap for "value" also leads to more consistency; after all stdWrap has been forgotten for this property. -
Chris topher voted on patch set 1 V +1 CR +1 12/16/13, 15:20
-
Helmut Hummel commented on patch set 1 12/16/13, 17:13
minor nitpickTextContentObject.php:47In which case does this make any sense? Is render called sometimes with something different than an array? If it's just a guard, I would prefer an array type hint in the method declaration or if that is not wanted for some reason throw an exeption if it's no array or (least preferable) do simply a typecast -
Markus Klein commented on patch set 1 12/16/13, 19:07
TextContentObject.php:47ReplyThx for your feedback Helmut. I transformed this only form the original code, where it did not make sense at all. First the is_array check and then a count() without a prior check... ? I remember that there is/was some reason why we can't use a typehint in the render methods. In order to not break any old code, I'd not throw an Exception here, but would just do the typecast. Is this ok from your side? -
Chris topher commented on patch set 1 01/23/14, 18:07
ping -
Helmut Hummel commented on patch set 1 01/31/14, 14:22
TextContentObject.php:45if (!is_array($conf)) { return ''; } -
Markus Klein uploaded patch set 2 02/01/14, 19:00
-
Markus Klein commented on patch set 1 02/01/14, 19:00
TextContentObject.php:45ReplyDone -
Benni Mack voted on patch set 2 CR +1 02/01/14, 19:04
-
Chris topher voted on patch set 2 V +1 CR +1 02/01/14, 19:08
-
Mr. Jenkins commented on patch set 2 02/01/14, 19:25
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13543/ : SUCCESS -
Stefan Neufeind voted on patch set 2 V +2 CR +2 02/01/14, 21:44
-
Stefan Neufeind merged patch set 3 02/01/14, 21:44
-
Stefan Neufeind commented on patch set 3 02/01/14, 21:44
Cherry Picked This patchset was cherry picked to change: I1b7068b3715bc9f8aa4608d5f746c16b70562f3b -
Stefan Neufeind commented on patch set 3 02/01/14, 21:45
Cherry Picked This patchset was cherry picked to change: I1b7068b3715bc9f8aa4608d5f746c16b70562f3b