26447[TASK] DatabaseConnection::isConnected() should use ping()
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Wouter Wolters +1
- Bill Dagou +1
-
Verified V +2
- Stefan Neufeind +2
- Bill Dagou +1
Issues 1
Files 1
Review log 9
-
Mr. Jenkins commented on patch set 1 12/16/13, 11:34
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12595/ : SUCCESS -
Christian Kuhn commented on patch set 1 12/16/13, 19:39
DatabaseConnection.php:2994did you test this? $this->link is not an object in dbal, i'd expect calling parent fails here. -
Markus Klein commented on patch set 1 CR -1 12/16/13, 23:12
DBAL change is not intended here.DatabaseConnection.php:2994ReplyNope, this is indeed a mistake. I didn't want to commit this change here. -
Markus Klein uploaded patch set 2 12/16/13, 23:13
-
Mr. Jenkins commented on patch set 2 12/16/13, 23:27
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12602/ : SUCCESS -
Bill Dagou voted on patch set 2 V +1 CR +1 01/24/14, 07:45
-
Wouter Wolters voted on patch set 2 CR +1 01/27/14, 21:47
-
Stefan Neufeind commented on patch set 2 V +2 CR +2 02/03/14, 22:49
Looks okay to me, works fine so far. Of course the "rare cases" are not really that easy to test :-) -
Stefan Neufeind merged patch set 3 02/03/14, 22:49