26482[TASK] Remove reference to old tx_templavoila nesting tag
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Dmitry Dulepov +2
- Wouter Wolters +1
- Fabien Udriot +1
-
Verified V +2
- Markus Klein +2
- Wouter Wolters +1
Issues 1
Files 1
Review log 24
-
Mr. Jenkins commented on patch set 1 12/18/13, 22:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12637/ : SUCCESS -
Wouter Wolters voted on patch set 1 CR +1 02/03/14, 18:29
-
Benni Mack voted on patch set 1 V +1 CR +1 02/03/14, 20:52
-
Stefan Neufeind commented on patch set 1 02/04/14, 00:18
In general okay with me. Would we need some way to clean up the flexform-entires that might still exist from a previous version maybe? Updater in the installer? People might upgrade from a lower version and still have that strange flexform around somewhere, right? -
Fabien Udriot voted on patch set 1 CR +1 02/07/14, 09:26
-
Markus Klein commented on patch set 1 CR +1 02/11/14, 23:53
Stefan, is such a migration wizard possible at all? Otherwise I'd prefer adding a NEWS.md entry concerning this change. -
Markus Klein uploaded patch set 2 02/17/14, 13:36
-
Markus Klein commented on patch set 2 02/17/14, 13:37
Added a deprecation log message.FormEngine.php:3030$new is unused. -
Markus Klein voted on patch set 2 CR +1 02/17/14, 13:37
-
Mr. Jenkins commented on patch set 2 02/17/14, 13:50
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14106/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/14105/ : SUCCESS -
Wouter Wolters voted on patch set 2 CR +1 02/17/14, 21:03
-
Dmitry Dulepov commented on patch set 2 CR -1 02/18/14, 08:41
See the inline comment.FormEngine.php:3032There is no check here that title is really within the tx_templavoila tag but the message is thrown. Not good. What if title is just not set? -
Markus Klein uploaded patch set 3 02/18/14, 08:46
-
Markus Klein commented on patch set 2 02/18/14, 08:46
FormEngine.php:3032ReplyDone -
Markus Klein voted on patch set 3 CR +1 02/18/14, 08:46
-
Mr. Jenkins commented on patch set 3 02/18/14, 09:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14136/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/14135/ : SUCCESS -
Wouter Wolters voted on patch set 3 CR +1 02/21/14, 19:41
-
Fabien Udriot voted on patch set 3 V +1 CR +1 02/22/14, 11:19
-
Fabien Udriot voted on patch set 3 V 0 02/22/14, 11:19
-
Dmitry Dulepov commented on patch set 3 CR +2 02/26/14, 12:03
How can I test this? -
Markus Klein commented on patch set 3 02/26/14, 14:25
Dmitry: Testing instructions are in the forge ticket. -
Wouter Wolters voted on patch set 3 V +1 03/06/14, 22:38
-
Markus Klein voted on patch set 3 V +2 CR +2 03/18/14, 09:58
-
Markus Klein merged patch set 4 03/18/14, 09:58