26536[BUGFIX] CharsetConverter::crop() calls utf8_char2byte_pos
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 4
-
Michiel Roos wrote 12/21/13, 23:55
Topic set to "performance". -
Mr. Jenkins commented on patch set 1 12/21/13, 23:59
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12690/ : SUCCESS -
Markus Klein commented on patch set 1 12/22/13, 14:45
Does it make sense to change this code at all? On default 6.2 installations the mbstring PHP extension is enabled by default by the Install Tool. So the remaining code of this method is useless.CharsetConverter.php:1672=== -
Michiel Roos abandoned the change 12/22/13, 18:37
You are right. The install tool should have set the mbstring preset for me, but did not since I used the TYPO3 Workbench install script to setup my environment. That does not yet handle the mbstring setting.