Review main Merged

26544[BUGFIX] Installer fails when no database is selected

Philipp Gampe CR +2 V +2 Easy +9 −3 updated 01/08/14, 23:07

Commit message

Display an error message, if the selected database name is empty.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Oliver Klee +1
    • Markus Klein +1
  • Verified V +2
    • Stefan Neufeind +2
    • Markus Klein +1

Issues 1

Files 2

Review log 13

  1. Markus Klein commented on patch set 1 12/22/13, 15:13

    Display an error message, if the selected database name is empty.

    DatabaseSelect.php:65

    Change the text here as well. ... or your database user probably does not have sufficient permissions to create it.
  2. Markus Klein commented on patch set 1 12/22/13, 15:14

    will push an update
  3. Markus Klein uploaded patch set 2 12/22/13, 15:16

  4. Mr. Jenkins commented on patch set 1 12/22/13, 15:16

  5. Markus Klein uploaded patch set 3 12/22/13, 15:21

  6. Markus Klein voted on patch set 3 V +1 CR +1 12/22/13, 15:24

  7. Mr. Jenkins commented on patch set 2 12/22/13, 15:29

  8. Mr. Jenkins commented on patch set 3 12/22/13, 15:35

  9. Philipp Gampe commented on patch set 3 12/22/13, 16:38

    thanks for the update Markus, wording looks OK now
  10. Stefan Neufeind voted on patch set 3 CR +1 12/26/13, 00:46

  11. Oliver Klee voted on patch set 3 CR +1 12/28/13, 00:01

  12. Stefan Neufeind voted on patch set 3 V +2 CR +2 01/08/14, 23:07

  13. Stefan Neufeind merged patch set 4 01/08/14, 23:07