Review main Merged

26578[BUGFIX] PropertyMapper does not work with class aliasses

Frans Saris CR +2 V +2 Easy +4 −3 updated 02/02/14, 18:28

Commit message

Currently the property mapper uses the classnames found
in the the class property annotations to find the right
TypeConverter. But for class aliases this breaks as the
alias is used and not the original classname.

There was already a getClassNameForAlias call but this was
to early.

This change moves the getClassNameForAlias() call from
doMapping() to findTypeConverter().

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Stefan Froemken +1
  • Verified V +2
    • Helmut Hummel +2
    • Stefan Froemken +1

Issues 1

Files 1

Review log 8

  1. Mr. Jenkins commented on patch set 1 12/29/13, 21:30

  2. Frans Saris uploaded patch set 2 02/02/14, 11:20

  3. Helmut Hummel voted on patch set 2 V +1 CR +1 02/02/14, 11:46

  4. Stefan Froemken commented on patch set 2 V +1 CR +1 02/02/14, 12:08

    Wonderful. Old classname was successfully changed to namespace version. Thank you.
  5. Helmut Hummel voted on patch set 2 V +2 CR +2 02/02/14, 12:12

  6. Helmut Hummel merged patch set 3 02/02/14, 12:12

  7. Helmut Hummel commented on patch set 3 02/02/14, 12:12

    Cherry Picked This patchset was cherry picked to change: Ie4ab3deb3c192290db62ea06826870d2fadba8a7
  8. Mr. Jenkins commented on patch set 2 02/02/14, 18:28