Review main Merged

26611[BUGFIX] Fix wording of encryption key in Installer

Markus Klein CR +2 V +2 Easy +1 −1 updated 01/08/14, 23:10

Commit message

The description of the encryption key uses the irregular verb
'output' in the wrong way.

Review

  • Code review CR +2
    • Stefan Neufeind +2
  • Verified V +2
    • Stefan Neufeind +2

Issues 1

Files 1

Review log 11

  1. Markus Klein updated the commit message in patch set 1 01/01/14, 20:29

  2. Oliver Klee voted on patch set 2 V +1 CR +1 01/01/14, 20:40

  3. Mr. Jenkins commented on patch set 2 01/01/14, 20:42

  4. Mr. Jenkins commented on patch set 1 01/01/14, 20:42

  5. Stefan Neufeind commented on patch set 2 CR -1 01/01/14, 20:45

    Guys, don't rush it. While I have the same feeling like you, I wonder why the Oxford Dictionary also knows "outputted": http://www.oxforddictionaries.com/us/definition/american_english/output I've asked a friend for a professional answer on this. Will let you know soon.
  6. Markus Klein commented on patch set 2 01/02/14, 17:01

    Good point Stefan, I asked some native speaker as well now. Looking forward to two different opinions now. :-D
  7. Franz Holzinger commented on patch set 2 01/02/14, 18:09

    I think that English always requires: Subject, Predicat, Object SPO So I would also add a second 'it'. It is a security relevant value and it is never output directly.
  8. Markus Klein uploaded patch set 3 01/08/14, 21:21

  9. Mr. Jenkins commented on patch set 3 01/08/14, 21:33

  10. Stefan Neufeind commented on patch set 3 V +2 CR +2 01/08/14, 23:10

    Okay like that.
  11. Stefan Neufeind merged patch set 4 01/08/14, 23:10