Review main Merged

26615[BUGFIX] EM does not always show description

Michiel Roos CR +2 V +2 Easy +20 −9 updated 01/03/14, 14:44

Commit message

When an extension (like rsaauth) has configuration options in the
extension manager, the description is not shown as a tooltip when hovering
over the extension name. Then it will only show 'Configure'. Which is not
so helpful.

The ConfigureExtensionViewHelper can be modified to not add a title
attribute on the link. This will ensure that the title attribute of the td
is shown.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Markus Klein +1
  • Verified V +2
    • Xavier Perseguers +2
    • Markus Klein +1

Issues 1

Files 3

Review log 11

  1. Mr. Jenkins commented on patch set 1 01/02/14, 08:38

  2. Markus Klein commented on patch set 1 CR -1 01/02/14, 16:59

    Please see my comment on forge and discuss possible solutions there first. Thanks.
  3. Michiel Roos uploaded patch set 2 01/02/14, 21:21

  4. Michiel Roos commented on patch set 2 01/02/14, 21:22

    * Added an extra language label: extensionList.clickToConfigure * Added an extra parameter 'showDescription' to the viewhelper
  5. Mr. Jenkins commented on patch set 2 01/02/14, 21:35

  6. Xavier Perseguers voted on patch set 2 V +1 CR +1 01/03/14, 08:31

  7. Markus Klein uploaded patch set 3 01/03/14, 12:31

  8. Markus Klein commented on patch set 3 V +1 CR +1 01/03/14, 12:31

    Reformatted code a bit
  9. Mr. Jenkins commented on patch set 3 01/03/14, 12:42

  10. Xavier Perseguers voted on patch set 3 V +2 CR +2 01/03/14, 14:44

  11. Xavier Perseguers merged patch set 4 01/03/14, 14:44