Review main Merged

26619[BUGFIX] Fix dependencies for non-composer extensions

Thomas Maroschik CR +2 V +2 Easy +16 −16 updated 01/09/14, 13:35

Commit message

The method packageRequirementIsComposerPackage of
TYPO3\CMS\Core\Package ignores all non composer package
names and thus dependency resolving of non composer packages
doesn't work.

This patch adapts the behavior to ignore just the platform
package links described here
http://getcomposer.org/doc/02-libraries.md#platform-packages

Review

  • Code review CR +2
    • Oliver Hader +2
    • Markus Klein +1
    • Anja Leichsenring +1
    • Stefan Froemken +1
  • Verified V +2
    • Oliver Hader +2
    • Markus Klein +1
    • Anja Leichsenring +1
    • Stefan Froemken +1

Files 3

Review log 17

  1. Mr. Jenkins commented on patch set 1 01/02/14, 11:21

  2. Markus Klein commented on patch set 1 01/02/14, 16:50

    Package.php:251

    Please make this code a bit nicer. return preg_match() !== 1;
  3. Stefan Froemken commented on patch set 1 01/03/14, 09:12

    Hello Thomas. The patch works for direct dependencies only, but not for recursive dependencies. Example: EXT:files needs EXT:jw_api and EXT:jw_api needs EXT:tt_news. If all extensions are deactivated and I click on install EXT:files only EXT:jw_api was installed too, but not EXT:tt_news.
  4. Kasper Ligaard commented on patch set 1 01/07/14, 07:22

    I would like your input to my comment in http://forge.typo3.org/issues/54142#note-4.
  5. Thomas Maroschik commented on patch set 1 01/07/14, 08:58

    @Stefan This is an EM issue and not an issue in the Package Management. It is already in 6.1 present. We need to figure out why the EM behaves so.
  6. Thomas Maroschik uploaded patch set 2 01/07/14, 09:00

  7. Stefan Froemken commented on patch set 1 V +1 01/07/14, 09:01

    With the new informations of Thomas I can set verified to +1. I have tested in in various combinations.
  8. Thomas Maroschik commented on patch set 1 01/07/14, 09:02

    Package.php:251 Reply

    Done
  9. Stefan Froemken voted on patch set 2 V +1 CR +1 01/07/14, 09:04

  10. Mr. Jenkins commented on patch set 2 01/07/14, 09:14

  11. Anja Leichsenring voted on patch set 2 V +1 CR +1 01/07/14, 11:07

  12. Markus Klein commented on patch set 2 V +1 CR +1 01/07/14, 12:58

    verified by unit tests
  13. Oliver Hader voted on patch set 2 CR +2 01/07/14, 13:34

  14. Oliver Hader commented on patch set 2 V +2 01/07/14, 13:35

    Code looks fine...
  15. Oliver Hader merged patch set 3 01/07/14, 13:35

  16. Kasper Ligaard commented on patch set 3 01/08/14, 10:45

    It is now impossible to installe extensions if you have uninstalled extensions in your typo3conf ext which depend on something that cannot be resolved. Say you have extension A in typo3conf/ext, but uninstalled. Extension A depends on extension B which cannot be found anywhere. Trying to install extension C you will just get: "Oops, an error occurred! The package "A" depends on "B" which is not present in the system. More information regarding this error might be available online." I short: You now cannot install any extensions at all!
  17. Helmut Hummel commented on patch set 3 01/09/14, 13:35

    @Kasper: Please test https://review.typo3.org/26719