Review TYPO3_4-7 Merged

26663[BUGFIX] Fix PHP fatal error in be.tableList view helper

Marc Bastian Heinrichs CR +2 V +2 Easy +3 −2 updated 01/16/14, 22:56

Commit message

The be.tableList view helper uses the class localRecordList
which relies on a available $GLOBALS['SOBE']->doc object.
Since https://review.typo3.org/19000/ the doc instance
in SOBE does not get instantiated in any case, which
results in a PHP fatal error using this view helper.

For 6.x this was fixed with https://review.typo3.org/15007/

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Oliver Klee +1
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Files 1

Review log 9

  1. Markus Klein updated the commit message in patch set 1 01/06/14, 19:29

  2. Markus Klein commented on patch set 2 01/06/14, 19:33

    Does this apply to 6.x as well?
  3. Wouter Wolters commented on patch set 2 CR +1 01/06/14, 19:34

    Reply

    See the commit message for the explanation about 6.x
  4. Markus Klein commented on patch set 2 CR +1 01/06/14, 19:44

    Reply

    *lol* Thx Wouter, just saw it, when I hit the button...
  5. Oliver Klee voted on patch set 2 CR +1 01/06/14, 21:20

  6. Markus Klein commented on patch set 2 V +1 01/16/14, 21:55

    Guys this is a rather simple backport. Please merge it.
  7. Wouter Wolters voted on patch set 2 V +2 CR +2 01/16/14, 21:57

  8. Wouter Wolters merged patch set 3 01/16/14, 21:57

  9. Markus Klein commented on patch set 3 01/16/14, 22:56

    Cherry Picked This patchset was cherry picked to change: I4ac4a1718ec6c8e0a02723802bf73dbabd1648ab