26686[BUGFIX] Unused TDParams in ColumnsContentObject()
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Wouter Wolters +1
-
Verified V +2
- Markus Klein +2
- Wouter Wolters +1
Issues 1
Files 1
Review log 13
-
Mr. Jenkins commented on patch set 1 01/07/14, 23:30
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12781/ : SUCCESS -
Markus Klein commented on patch set 1 01/08/14, 10:43
What about 6.0? -
Wouter Wolters commented on patch set 1 01/08/14, 10:57
Reply
I talked about this with Michiel yesterday evening and don't see the need of backporting this.. -
Michiel Roos commented on patch set 1 01/08/14, 10:58
Reply
I guess it's in there too. But that was 'end of lifed' in October 2013. -
Markus Klein commented on patch set 1 01/08/14, 11:09
Reply
ok true. but 4.x is in important bugfix only state. So the question, is this that important? (we'd need RM clearance for 4.x anyway) -
Michiel Roos commented on patch set 1 01/08/14, 11:51
Reply
It's for setting attributes on the table cell in columns object; like 'valign="top" etc. I searched the issue tracker and did not find any related bug reports when searching for 'tdparams' or 'columns'. So I guess this is of low importance. I just stumbled upon it thanks to PHPStorm greying out the unused variable. We should do a complete scan of the source for these bugs. -
Wouter Wolters updated the commit message in patch set 1 02/03/14, 17:33
-
Wouter Wolters uploaded patch set 3 02/03/14, 17:36
-
Wouter Wolters voted on patch set 3 V +1 CR +1 02/03/14, 17:37
-
Mr. Jenkins commented on patch set 2 02/03/14, 18:32
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13656/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13655/ : SUCCESS -
Mr. Jenkins commented on patch set 3 02/03/14, 18:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13657/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13656/ : SUCCESS -
Markus Klein voted on patch set 3 V +2 CR +2 02/03/14, 18:53
-
Markus Klein merged patch set 4 02/03/14, 18:53