Review main Merged

26686[BUGFIX] Unused TDParams in ColumnsContentObject()

Michiel Roos CR +2 V +2 Easy +1 −1 updated 02/03/14, 18:53

Commit message

TypoScript configuration for TDParams is assigned to the PHP variable
$TDParams which is never used. The rest of the method uses $TDparams.

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 13

  1. Mr. Jenkins commented on patch set 1 01/07/14, 23:30

  2. Markus Klein commented on patch set 1 01/08/14, 10:43

    What about 6.0?
  3. Wouter Wolters commented on patch set 1 01/08/14, 10:57

    Reply

    I talked about this with Michiel yesterday evening and don't see the need of backporting this..
  4. Michiel Roos commented on patch set 1 01/08/14, 10:58

    Reply

    I guess it's in there too. But that was 'end of lifed' in October 2013.
  5. Markus Klein commented on patch set 1 01/08/14, 11:09

    Reply

    ok true. but 4.x is in important bugfix only state. So the question, is this that important? (we'd need RM clearance for 4.x anyway)
  6. Michiel Roos commented on patch set 1 01/08/14, 11:51

    Reply

    It's for setting attributes on the table cell in columns object; like 'valign="top" etc. I searched the issue tracker and did not find any related bug reports when searching for 'tdparams' or 'columns'. So I guess this is of low importance. I just stumbled upon it thanks to PHPStorm greying out the unused variable. We should do a complete scan of the source for these bugs.
  7. Wouter Wolters updated the commit message in patch set 1 02/03/14, 17:33

  8. Wouter Wolters uploaded patch set 3 02/03/14, 17:36

  9. Wouter Wolters voted on patch set 3 V +1 CR +1 02/03/14, 17:37

  10. Mr. Jenkins commented on patch set 2 02/03/14, 18:32

  11. Mr. Jenkins commented on patch set 3 02/03/14, 18:46

  12. Markus Klein voted on patch set 3 V +2 CR +2 02/03/14, 18:53

  13. Markus Klein merged patch set 4 02/03/14, 18:53