26687[TASK] Cleanup ContentObject\ContentObjectRenderer
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Oliver Klee +1
- Markus Klein +1
-
Verified V +2
- Wouter Wolters +2
- Markus Klein +1
Issues 1
Files 1
Review log 12
-
Mr. Jenkins commented on patch set 1 01/08/14, 00:44
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12782/ : SUCCESS -
Markus Klein voted on patch set 1 V +1 CR +1 01/08/14, 11:00
-
Wouter Wolters commented on patch set 1 CR +1 01/08/14, 11:04
will test laterContentObjectRenderer.php:2545why set $content empty again? -
Michiel Roos commented on patch set 1 01/08/14, 11:11
ContentObjectRenderer.php:2545ReplyMaybe it was not a string when it came into the function? We need to inspect the callers. -
Oliver Klee commented on patch set 1 01/08/14, 17:51
ContentObjectRenderer.php:719AFAIK, the array notation for strings is deprecated, and the {0} notation should be used instead. -
Markus Klein commented on patch set 1 CR -1 01/08/14, 17:54
ContentObjectRenderer.php:719ReplyGood catch! thx -
Markus Klein uploaded patch set 2 01/08/14, 17:55
-
Oliver Klee voted on patch set 2 CR +1 01/08/14, 17:57
-
Markus Klein voted on patch set 2 V +1 CR +1 01/08/14, 17:58
-
Mr. Jenkins commented on patch set 2 01/08/14, 18:10
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12796/ : SUCCESS -
Wouter Wolters voted on patch set 2 V +2 CR +2 01/08/14, 19:10
-
Wouter Wolters merged patch set 3 01/08/14, 19:10