Review main Merged

26687[TASK] Cleanup ContentObject\ContentObjectRenderer

Michiel Roos CR +2 V +2 Normal +59 −114 updated 01/08/14, 19:10

Commit message

Implement early return for many methods.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Oliver Klee +1
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 1

Review log 12

  1. Mr. Jenkins commented on patch set 1 01/08/14, 00:44

  2. Markus Klein voted on patch set 1 V +1 CR +1 01/08/14, 11:00

  3. Wouter Wolters commented on patch set 1 CR +1 01/08/14, 11:04

    will test later

    ContentObjectRenderer.php:2545

    why set $content empty again?
  4. Michiel Roos commented on patch set 1 01/08/14, 11:11

    ContentObjectRenderer.php:2545 Reply

    Maybe it was not a string when it came into the function? We need to inspect the callers.
  5. Oliver Klee commented on patch set 1 01/08/14, 17:51

    ContentObjectRenderer.php:719

    AFAIK, the array notation for strings is deprecated, and the {0} notation should be used instead.
  6. Markus Klein commented on patch set 1 CR -1 01/08/14, 17:54

    ContentObjectRenderer.php:719 Reply

    Good catch! thx
  7. Markus Klein uploaded patch set 2 01/08/14, 17:55

  8. Oliver Klee voted on patch set 2 CR +1 01/08/14, 17:57

  9. Markus Klein voted on patch set 2 V +1 CR +1 01/08/14, 17:58

  10. Mr. Jenkins commented on patch set 2 01/08/14, 18:10

  11. Wouter Wolters voted on patch set 2 V +2 CR +2 01/08/14, 19:10

  12. Wouter Wolters merged patch set 3 01/08/14, 19:10