Review main Merged

26695[BUGFIX] Suggest Wizard: support for PAGE_TSCONFIG_*-values in addWhere

Julian Hofmann CR +2 V +2 Easy +15 −2 updated 07/07/14, 20:20

Commit message

Using PAGE_TSCONFIG_*-values in the foreign_table_where-clause limits
the entries. This where clause is also used for the suggest wizard, but
the markers are not replaced there.
PAGE_TSCONFIG_*-values are now supported in the suggest wizard too.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 1

Review log 22

  1. Mr. Jenkins commented on patch set 1 01/08/14, 17:52

  2. Markus Klein commented on patch set 1 01/08/14, 18:01

    Julian thanks for your contribution. See my comments please.
    Features are only allowed to go into new versions. 6.2 is already in feature freeze so this has to go into the successor of 6.2
    Change-Id must NOT be a separate paragraph. Please make sure you're using the correct commit message hook linked in the Wiki (http://wiki.typo3.org/CWT)
  3. Julian Hofmann updated the commit message in patch set 1 01/08/14, 18:44

  4. Mr. Jenkins commented on patch set 2 01/08/14, 18:55

  5. Markus Klein uploaded patch set 3 07/06/14, 21:48

  6. Markus Klein commented on patch set 3 07/06/14, 21:48

    I improved the solution a bit to avoid PHP notices/warnings. I repeat my question from forge here: Is it a feature or more a bugfix?
  7. Mr. Jenkins commented on patch set 3 07/06/14, 22:02

  8. Wouter Wolters commented on patch set 3 07/06/14, 22:13

    I tend to say this is a bugfix. Can be useful and is done in many other places. 6.3 and 6.2 should be fine. Documentation issue needs to be created.
  9. Markus Klein updated the commit message in patch set 3 07/06/14, 23:44

  10. Markus Klein commented on patch set 4 07/06/14, 23:44

    I can't even find a documentation about the addWhere itself... am I blind?
  11. Mr. Jenkins commented on patch set 4 07/07/14, 00:05

  12. Julian Hofmann commented on patch set 4 V +1 CR +1 07/07/14, 07:12

    You're right, "addWhere" seems not to be documented for suggest wizard yet.
  13. Wouter Wolters commented on patch set 4 CR -1 07/07/14, 18:05

    wrong check for isset

    SuggestElement.php:252

    PAGE_TSCONFIG_IDLIST

    SuggestElement.php:255

    PAGE_TSCONFIG_STR
  14. Wouter Wolters uploaded patch set 5 07/07/14, 18:29

  15. Wouter Wolters voted on patch set 5 V +1 CR +1 07/07/14, 18:30

  16. Mr. Jenkins commented on patch set 5 07/07/14, 18:43

  17. Markus Klein updated the commit message in patch set 5 07/07/14, 20:06

  18. Markus Klein voted on patch set 6 V +1 CR +1 07/07/14, 20:06

  19. Wouter Wolters voted on patch set 6 V +2 CR +2 07/07/14, 20:14

  20. Wouter Wolters merged patch set 7 07/07/14, 20:14

  21. Wouter Wolters commented on patch set 7 07/07/14, 20:14

    Cherry Picked This patchset was cherry picked to change: Ieb53d48ca0ddf22bbbbc4aed4d1e83220a82ec09
  22. Mr. Jenkins commented on patch set 6 07/07/14, 20:20