Review main Merged

26718[TASK] Be more expressive in error condition

Helmut Hummel CR +2 V +2 Easy +5 −12 updated 01/29/14, 10:30

Commit message

If lockSSL is set to 1 and the backend is not
accessed via SSL currently a 404 header is sent
with no message body. The same happens when the
client IP address does not mach the configured
list of allowed addresses.

Give a more useful hint for users in these cases
by throwing an Exception.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Oliver Klee +1
    • Markus Klein +1
    • Michiel Roos +1
    • Marcin Sągol +1
    • Felix Kopp +1
  • Verified V +2
    • Helmut Hummel +2
    • Georg Ringer +1
    • Markus Klein +1
    • Michiel Roos +1

Issues 1

Files 1

Review log 12

  1. Michiel Roos voted on patch set 1 V +1 CR +1 01/09/14, 11:26

  2. Mr. Jenkins commented on patch set 1 01/09/14, 11:31

  3. Georg Ringer commented on patch set 1 V +1 01/09/14, 13:09

    Bootstrap.php:868

    what about also adding where to change it, which means changing it to something like: TYPO3 Backend access denied: The IP address of your client does not match the list of allowed IP addresses defined in the section "BE" => IPmaskList in the Install Tool?

    Bootstrap.php:904

    also add hint to BE lockSSL
  4. Oliver Klee voted on patch set 1 CR +1 01/10/14, 00:58

  5. Stefan Neufeind commented on patch set 1 01/21/14, 23:42

    Bootstrap.php:868 Reply

    Imho possibly too much. This might also be shown to not-admins.

    Bootstrap.php:904 Reply

    yes
  6. Markus Klein commented on patch set 1 01/22/14, 00:04

    Bootstrap.php:868 Reply

    I'd document this on the wiki pages linked in the exception.

    Bootstrap.php:904 Reply

    I'd document this on the wiki pages linked in the exception.
  7. Markus Klein commented on patch set 1 V +1 CR +1 01/22/14, 00:09

    In case somebody pushes a new version of the patch please adjust 'TYPO3' to 'TYPO3 CMS' in the messages.
  8. Marcin Sągol voted on patch set 1 CR +1 01/22/14, 02:24

  9. Felix Kopp commented on patch set 1 CR +1 01/22/14, 09:13

    Bootstrap.php:868

    Great to get the messages out and to improve guidance. I Think we might further with visual error messages later on. For now I like the approach. I ersonally would change the word "client" since client has several meanings: "Access to the TYPO3 backend denied because your IP address is blocked currently. Please contact your TYPO3 administrator." Howto should be solved in the wiki.

    Bootstrap.php:904 Reply

    "You can only access the TYPO3 backend securely through SSL. Please type in address starting with 'https' into the address bar instead."
  10. Stefan Neufeind commented on patch set 1 01/23/14, 23:50

    Could somebody sum up the comments please? I think we should get this done.
  11. Helmut Hummel commented on patch set 1 V +2 CR +2 01/29/14, 10:30

    Since the exception message only appears when a user is logged in or the client ip matches devIP mask, I think the message does not matter much (must not be end user friendly). Besides that information can be added to the wiki page and if it is really pressing, we still can change the message again. Now merging since we have enough votes.
  12. Helmut Hummel merged patch set 2 01/29/14, 10:30