Review main Merged

26723[BUGFIX] Allow empty values in start/stop filter of belog

Steffen Müller CR +2 V +2 Normal +86 −2 updated 01/09/14, 19:37

Commit message

One can limit records in the backend log module to a custom period
of time using the "User defined" mode and a start and stop field.

Leaving these fields empty is now supported in the corresponding
domain model setters by adding default values to the DateTime
arguments.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 2

Review log 9

  1. Wouter Wolters voted on patch set 1 CR +1 01/09/14, 15:08

  2. Mr. Jenkins commented on patch set 1 01/09/14, 15:16

  3. Steffen Müller uploaded patch set 2 01/09/14, 17:54

  4. Steffen Müller commented on patch set 2 01/09/14, 17:55

    Added unit tests to demonstrate the issue.
  5. Mr. Jenkins commented on patch set 2 01/09/14, 18:13

  6. Markus Klein commented on patch set 2 V +1 CR +1 01/09/14, 19:01

    This is such a no-brainer...
  7. Wouter Wolters voted on patch set 2 V +2 CR +2 01/09/14, 19:37

  8. Wouter Wolters merged patch set 3 01/09/14, 19:37

  9. Wouter Wolters commented on patch set 3 01/09/14, 19:37

    Cherry Picked This patchset was cherry picked to change: I944322bb3747a29fab33c3d32e17dd070c7cb6db