Review main Merged

26729[BUGFIX] Repair f:image VH for Backend

Stefan Froemken CR +2 V +2 Easy +2 −1 updated 01/21/14, 14:49

Commit message

ImageMagick command was executed from directory
typo3/, but output file is relative and starts
with typo3temp.
This patch adds absolute path to output file
when in BE mode.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Xavier Perseguers +2
    • Oliver Klee +1
    • Marcin Sągol +1
  • Verified V +2
    • Stefan Neufeind +2
    • Marcin Sągol +1
    • Xavier Perseguers +1

Issues 1

Files 1

Review log 26

Show 1 earlier messages
  1. Stefan Froemken uploaded patch set 2 01/09/14, 21:33

  1. Mr. Jenkins commented on patch set 1 01/09/14, 21:42

  2. Mr. Jenkins commented on patch set 2 01/09/14, 21:46

  3. Markus Klein voted on patch set 2 CR +1 01/09/14, 22:31

  4. Stefan Neufeind commented on patch set 2 CR +1 01/15/14, 01:37

    GraphicalFunctions.php:2274

    Since the long part of this row is all the same, how about maybe putting this into one statement, so it's easier to see the rest of the line is exactly the same?
  5. Stefan Froemken commented on patch set 2 01/15/14, 08:17

    GraphicalFunctions.php:2274 Reply

    Moin Stefan. I decided that way, because this row is very long. When adding your mentioned way, the row gets larger and you have to scroll horizontal in PhpStorm or you have to realize this part with 7 lines instead of 5. In my kind of view, this is the best readable version.
  6. Oliver Klee commented on patch set 2 01/15/14, 10:23

    GraphicalFunctions.php:2274 Reply

    Or put the long part in a local well-named variable.
  7. Stefan Froemken commented on patch set 2 01/15/14, 10:28

    GraphicalFunctions.php:2274 Reply

    @Olli: This is a deal :-) I will provide a new patch.
  8. Stefan Froemken uploaded patch set 3 01/15/14, 10:39

  9. Stefan Neufeind commented on patch set 3 CR +1 01/15/14, 10:49

    Looks great :-) Do you have an example where an image-VH is used in BE-mode? Any extension or so?
  10. Mr. Jenkins commented on patch set 3 01/15/14, 10:53

  11. Oliver Klee voted on patch set 3 CR +1 01/15/14, 11:18

  12. Stefan Froemken commented on patch set 3 01/15/14, 12:36

    My extension needs a special environment and two additional extensions to work. So it's much easier to build your own little ext with extension_builder and insert a huge image resized to 16*16 px. If it was resized the patch works.
  13. Xavier Perseguers voted on patch set 3 CR +1 01/19/14, 15:31

  14. Xavier Perseguers voted on patch set 3 V +1 CR +2 01/19/14, 15:36

  15. Marcin Sągol voted on patch set 3 CR +1 01/19/14, 19:34

  16. Marcin Sągol voted on patch set 3 V +1 01/19/14, 20:07

  17. Stefan Neufeind voted on patch set 3 V +2 CR +2 01/20/14, 07:20

  18. Stefan Neufeind merged patch set 4 01/20/14, 07:20

  19. Helmut Hummel commented on patch set 4 01/20/14, 20:37

    GraphicalFunctions.php:2274

    I don't like the way it is fixed here. It introduces a constant dependency to the code and removes the possibility to change absPrefix in BE mode. I would have preferred the fix here: https://review.typo3.org/23652
  20. Helmut Hummel commented on patch set 4 01/20/14, 20:39

    Do we leave the code like it is? Or revert in favour of https://review.typo3.org/23652 ?
  21. Markus Klein commented on patch set 4 01/20/14, 20:51

    I think it's a question of method: Should GraphicsUtility be "working directory aware" or should the proper path be injected from outside. If the latter is the way to, I'm +1 for reverting and going with the other patch.
  22. Helmut Hummel commented on patch set 4 01/21/14, 14:24

    Well, $this->absPrefix was already there and could have been used to be set to a specific path (actually was use in 4.7 and below in BE context exactly like that). Other than that, what is preferred? Strongly coupled code (the code is now bound to TYPO3_MODE and PATH_site) or decoupled code where configuration is injected from the "outside".
  23. Markus Klein commented on patch set 4 01/21/14, 14:30

    The more generic, the better. I didn't know of the other patch before and therefore agree to reverting and using the less coupled code.
  24. Helmut Hummel commented on patch set 4 01/21/14, 14:48

    Reverted This patchset was reverted in change: I0a297b9ae85e0b02ad3753d752abe4f31f260c12
  25. Helmut Hummel commented on patch set 4 01/21/14, 14:49

    Thanks for the work on this issue anyway and sorry that I did not manage to get my change in for so long (I failed to provide possibilities to test)!