Review TYPO3_6-0 Abandoned

26731[BUGFIX] File browser fails on inexistent expandFolder

Mario Rimann CR 0 V 0 Easy +9 −1 updated 01/16/14, 22:29

Commit message

If a user browsed to a directory "foo" and re-opens the file-
browser later, the same directory is shown expanded.

In case the directory has been moved/renamed/deleted in the
meantime, the user gets an exception due to the inexistent
directory.

This change just adds a try/catch block around to handle that
situation.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 5

  1. Mario Rimann commented on patch set 1 01/10/14, 08:23

    Straight Backport
  2. Markus Klein commented on patch set 1 CR -1 01/16/14, 18:23

    You didn't keep the change-id from the original patch!!
  3. Markus Klein abandoned the change 01/16/14, 18:28

    Repushed with correct change-id
  4. Mario Rimann commented on patch set 1 01/16/14, 22:23

    Sorry for messing with the Change-Id. I was 100% sure that I need to remove the automatically added lines from the commit message, including the Change-Id-Line - but I checked the wiki for that and you're right of course. But, referring to the wiki page's history, it was requested to remove that line, too - at least in the early days :-)
  5. Wouter Wolters commented on patch set 1 01/16/14, 22:29

    Back in the days Gerrit Code Review could not handle the change-id to be the same and use it as reference to check the backports. We used the topic for that but it works now and the topic is not needed anymore:)