Review main Merged

26741[BUGFIX] Extension Upload ends in PHP Error

Rico Sonntag CR +2 V +2 Easy +8 −0 updated 02/17/14, 12:58

Commit message

Adds an additional check after processing of the ext_emconf.php, throwing
an exception if EmConfUtility::includeEmConf returns FALSE.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2

Files 1

Review log 19

  1. Mr. Jenkins commented on patch set 1 01/10/14, 14:26

  2. Markus Klein commented on patch set 1 CR +1 01/10/14, 14:45

    Thanks for you perfect contribution!
  3. Wouter Wolters voted on patch set 1 CR +1 01/10/14, 14:49

  4. Christian Kuhn commented on patch set 1 01/29/14, 20:30

    InstallUtility.php:214

    $code missing
  5. Christian Kuhn commented on patch set 1 CR -1 01/29/14, 23:15

    InstallUtility.php:211

    Mmmh, smells funny somehow and misplaced. If this patch is about ext_emconf, the exception may be better placed in EmConfUtility includeEmConf()? Aditionaly, enrichExtensionWithDetails() is also called within action controller install action, so the exception message is not always bound to an extension upload?
  6. Markus Klein commented on patch set 1 CR 0 02/03/14, 12:59

    InstallUtility.php:211 Reply

    I only partially agree Christian. The check here is very valid, since we can't return an undefined index of the array below. What problem do you expect with the exception being thrown though?

    InstallUtility.php:214 Reply

    Done
  7. Markus Klein uploaded patch set 2 02/03/14, 13:00

  8. Markus Klein voted on patch set 2 CR +1 02/03/14, 13:00

  9. Xavier Perseguers voted on patch set 2 CR +1 02/03/14, 13:13

  10. Wouter Wolters voted on patch set 2 CR +1 02/03/14, 16:11

  11. Mr. Jenkins commented on patch set 2 02/03/14, 16:25

  12. Christian Weiske commented on patch set 2 V +1 CR +1 02/13/14, 15:32

    The patch works fine and warns the user about a broken ext_emconf.php.
  13. Markus Klein commented on patch set 2 02/13/14, 17:49

    @Christian K: You mentioned a possible problem with this exception being thrown. Where do you expect that problem?
  14. Oliver Klee voted on patch set 2 CR +1 02/13/14, 17:51

  15. Stefan Neufeind commented on patch set 2 CR +1 02/16/14, 17:09

    @Christian: About what were you concerned?
  16. Markus Klein uploaded patch set 3 02/17/14, 12:44

  17. Markus Klein commented on patch set 3 V +2 CR +2 02/17/14, 12:45

    Just added a dot in the end of the last sentence. Merging with last votes which where r+8 and v+1
  18. Markus Klein merged patch set 4 02/17/14, 12:45

  19. Mr. Jenkins commented on patch set 3 02/17/14, 12:58