Review main Merged

26756[TASK] Fix category collection functional test

Tymoteusz Motylewski CR +2 V +2 Normal +10 −46 updated 01/23/14, 15:19

Commit message

Category collection test now extends FunctionalTestCase
class and is green again.

Review

  • Code review CR +2
    • Francois Suter +2
    • Oliver Klee +1
    • Marcin Sągol +1
    • Fabien Udriot +1
    • Marc Bastian Heinrichs +1
  • Verified V +2
    • Francois Suter +2
    • Marcin Sągol +1
    • Marc Bastian Heinrichs +1

Issues 1

Files 1

Review log 13

  1. Oliver Klee voted on patch set 1 CR +1 01/11/14, 18:57

  2. Mr. Jenkins commented on patch set 1 01/11/14, 19:25

  3. Marc Bastian Heinrichs commented on patch set 1 V +1 CR +1 01/17/14, 15:16

    Jep, tests are green again.
  4. Marcin Sągol commented on patch set 1 V +1 CR +1 01/17/14, 18:10

    Looks good to me.
  5. Fabien Udriot voted on patch set 1 CR +1 01/18/14, 06:13

  6. Michiel Roos commented on patch set 1 01/22/14, 21:29

    Success! 9 tests, 0 assertions, 0 failures, 9 skipped So all 9 tests are still skipped.
  7. Francois Suter commented on patch set 1 01/23/14, 07:37

    I get 9 skipped tests too running command: php typo3/cli_dispatch.phpsh phpunit typo3/sysext/core/Tests/Functional/Category/Collection/CategoryCollectionTest.php Are there some special arguments to add for this test to run properly? It says the same thing as with the BE module: "Functional tests must be called through phpunit on CLI". I tried running the test directly via the phpunit PHAR, using: phpunit typo3/sysext/core/Tests/Functional/Category/Collection/CategoryCollectionTest.php but then I get the following error: "Fatal error: Class 'TYPO3\CMS\Core\Tests\FunctionalTestCase' not found in /usr/local/src/typo3/Core/typo3/sysext/core/Tests/Functional/Category/Collection/CategoryCollectionTest.php on line 33" For those who gave a Verified +1, how did you get the test running properly?
  8. Wouter Wolters commented on patch set 1 01/23/14, 07:47

    Try this command: ./typo3conf/ext/phpunit/Composer/vendor/bin/phpunit -c typo3/sysext/core/Build/FunctionalTests.xml
  9. Francois Suter commented on patch set 1 01/23/14, 08:10

    Even worse, now I get only errors. The output complains about "Undefined index: database". Mind you, it does this for all functional tests, so it's probably something missing in my setup or some option in the command to run. I'll ask in the Core list I guess.
  10. Marc Bastian Heinrichs commented on patch set 1 01/23/14, 08:32

    Hey guys, have a look at http://wiki.typo3.org/Functional_testing - your database user needs to be allowed to create databases. You could run the CategoryCollection test with this command: ./typo3conf/ext/phpunit/Composer/vendor/bin/phpunit --colors -v --process-isolation --bootstrap typo3/sysext/core/Build/FunctionalTestsBootstrap.php typo3/sysext/core/Tests/Functional/Category/Collection/CategoryCollectionTest.php
  11. Francois Suter commented on patch set 1 01/23/14, 09:02

    Thanks for the info. Still does not work properly though, continuing the discussion in the Core list.
  12. Francois Suter commented on patch set 1 V +2 CR +2 01/23/14, 15:19

    Finally got it running properly when using: ./typo3conf/ext/phpunit/Composer/vendor/bin/phpunit --colors -v --process-isolation --bootstrap typo3/sysext/core/Build/FunctionalTestsBootstrap.php typo3/sysext/core/Tests/Functional/Category/Collection/CategoryCollectionTest.php and removing extension "about" (don't know why, but it's not related to this patch; it blocked all functional tests).
  13. Francois Suter merged patch set 2 01/23/14, 15:19