26777[BUGFIX] Static method cannot be abstract
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 1
Review log 14
-
Markus Klein commented on patch set 1 01/13/14, 09:58
-
Xavier Perseguers uploaded patch set 2 01/13/14, 10:03
-
Eric Chavaillaz voted on patch set 2 CR +1 01/13/14, 10:05
-
Markus Klein voted on patch set 2 V +1 CR +1 01/13/14, 10:05
-
Wouter Wolters wrote 01/13/14, 10:07
Topic set to "fal". -
Mr. Jenkins commented on patch set 1 01/13/14, 10:21
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12925/ : SUCCESS -
Mr. Jenkins commented on patch set 2 01/13/14, 11:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12932/ : SUCCESS -
Oliver Klee voted on patch set 2 CR +1 01/13/14, 13:04
-
Steffen Ritter commented on patch set 2 CR -1 01/13/14, 13:06
I would opt for removing it - the function is never used; besides in the unit tests which checks extistence in the driver refactoring I removed it -
Steffen Ritter commented on patch set 2 CR -2 01/15/14, 14:11
Hey guys, we merged the driver refactoring ... So this one is obsolete for 6.2; anyhow I'm +1 for 6.1 if you think it's important, else please consider abandoning that patch. -
Markus Klein commented on patch set 2 01/15/14, 14:29
Yes Steffen, I knew that your changes comes along. I'm for having this in 6.1 and 6.0 since it's a syntactical fault. -
Steffen Ritter commented on patch set 2 01/15/14, 14:31
as I said, I'm +1 reading for the old versions :) anyhow this one needs to be abandoned and repushed for 6.1 -
Markus Klein commented on patch set 2 01/15/14, 14:31
Pushed patch to https://review.typo3.org/26843 for 6.1 -
Xavier Perseguers abandoned the change 01/21/14, 16:54
No need anymore in master
AbstractDriver.php:141