Review main Abandoned

26777[BUGFIX] Static method cannot be abstract

Xavier Perseguers CR 0 V 0 Easy +4 −2 updated 01/21/14, 16:54

Commit message

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 14

  1. Markus Klein commented on patch set 1 01/13/14, 09:58

    AbstractDriver.php:141

    remove this and add @throws
  2. Xavier Perseguers uploaded patch set 2 01/13/14, 10:03

  3. Eric Chavaillaz voted on patch set 2 CR +1 01/13/14, 10:05

  4. Markus Klein voted on patch set 2 V +1 CR +1 01/13/14, 10:05

  5. Wouter Wolters wrote 01/13/14, 10:07

    Topic set to "fal".
  6. Mr. Jenkins commented on patch set 1 01/13/14, 10:21

  7. Mr. Jenkins commented on patch set 2 01/13/14, 11:14

  8. Oliver Klee voted on patch set 2 CR +1 01/13/14, 13:04

  9. Steffen Ritter commented on patch set 2 CR -1 01/13/14, 13:06

    I would opt for removing it - the function is never used; besides in the unit tests which checks extistence in the driver refactoring I removed it
  10. Steffen Ritter commented on patch set 2 CR -2 01/15/14, 14:11

    Hey guys, we merged the driver refactoring ... So this one is obsolete for 6.2; anyhow I'm +1 for 6.1 if you think it's important, else please consider abandoning that patch.
  11. Markus Klein commented on patch set 2 01/15/14, 14:29

    Yes Steffen, I knew that your changes comes along. I'm for having this in 6.1 and 6.0 since it's a syntactical fault.
  12. Steffen Ritter commented on patch set 2 01/15/14, 14:31

    as I said, I'm +1 reading for the old versions :) anyhow this one needs to be abandoned and repushed for 6.1
  13. Markus Klein commented on patch set 2 01/15/14, 14:31

    Pushed patch to https://review.typo3.org/26843 for 6.1
  14. Xavier Perseguers abandoned the change 01/21/14, 16:54

    No need anymore in master