Review main Merged

26779[BUGFIX] Only variables should be passed by reference

Xavier Perseguers CR +2 V +2 Easy +2 −1 updated 01/13/14, 21:00

Commit message

array_shift() takes argument by reference.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Markus Klein +1
  • Verified V +2
    • Stefan Neufeind +2
    • Markus Klein +1

Files 1

Review log 9

  1. Thomas Maroschik voted on patch set 1 CR +1 01/13/14, 10:03

  2. Eric Chavaillaz voted on patch set 1 CR +1 01/13/14, 10:04

  3. Markus Klein voted on patch set 1 V +1 CR +1 01/13/14, 10:11

  4. Markus Klein updated the commit message in patch set 1 01/13/14, 10:12

  5. Markus Klein voted on patch set 2 V +1 CR +1 01/13/14, 10:12

  6. Mr. Jenkins commented on patch set 1 01/13/14, 10:59

  7. Mr. Jenkins commented on patch set 2 01/13/14, 11:41

  8. Stefan Neufeind voted on patch set 2 V +2 CR +2 01/13/14, 21:00

  9. Stefan Neufeind merged patch set 3 01/13/14, 21:00