Review main Merged

26781[BUGFIX] Display detected fatal in extension check

Thomas Maroschik CR +2 V +2 Normal +60 −0 updated 01/29/14, 19:04

Commit message

In the installer fatals can happen during updates of
very outdated extensions. Many updates can lead to a
redirect to the extension check where the user gets
displayed a message that a fatal has been detected.
But the detected fatal error itself is not displayed.

This patch passes the error as url parameter to the
extension check and displays it there.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Thomas Maroschik +1
    • Markus Klein +1
    • Wouter Wolters +1
    • Anja Leichsenring +1
    • Helmut Hummel +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Anja Leichsenring +1
    • Helmut Hummel +1

Files 5

Review log 24

  1. Markus Klein commented on patch set 1 01/13/14, 11:30

    ToolController.php:172

    shouldn't this be ||?
  2. Thomas Maroschik uploaded patch set 2 01/13/14, 11:34

  3. Thomas Maroschik commented on patch set 1 01/13/14, 11:34

    ToolController.php:172 Reply

    Done
  4. Markus Klein voted on patch set 2 CR +1 01/13/14, 11:43

  5. Wouter Wolters voted on patch set 2 CR +1 01/13/14, 11:48

  6. Mr. Jenkins commented on patch set 1 CR -1 V -1 01/13/14, 11:54

  7. Mr. Jenkins commented on patch set 2 01/13/14, 12:00

  8. Stefan Neufeind voted on patch set 2 CR +1 01/16/14, 22:56

  9. Anja Leichsenring voted on patch set 2 V +1 CR +1 01/29/14, 10:48

  10. Helmut Hummel commented on patch set 2 01/29/14, 11:06

    ToolController.php:136

    I would find it nicer, if we could store this in the session (if that is possible) Passing it by GET offers so many possibilities to abuse/attack
  11. Christian Kuhn commented on patch set 2 01/29/14, 11:12

    nice. will review this evening.
  12. Helmut Hummel uploaded patch set 3 01/29/14, 12:35

  13. Helmut Hummel voted on patch set 3 V +1 CR +1 01/29/14, 12:36

  14. Thomas Maroschik voted on patch set 3 CR +1 01/29/14, 12:40

  15. Wouter Wolters voted on patch set 3 CR +1 01/29/14, 12:42

  16. Mr. Jenkins commented on patch set 3 01/29/14, 12:49

  17. Stefan Neufeind voted on patch set 3 CR +1 01/29/14, 13:09

  18. Markus Klein voted on patch set 3 CR +1 01/29/14, 14:55

  19. Anja Leichsenring voted on patch set 3 V +1 CR +1 01/29/14, 15:50

  20. Wouter Wolters commented on patch set 3 V +1 01/29/14, 18:16

    Christian announced to also have a look. Will contact him.
  21. Wouter Wolters wrote 01/29/14, 18:17

    Topic set to "install-tool".
  22. Christian Kuhn commented on patch set 3 01/29/14, 18:42

    I'll give it a shot now.
  23. Christian Kuhn commented on patch set 3 V +2 CR +2 01/29/14, 19:04

    good! thx!
  24. Christian Kuhn merged patch set 4 01/29/14, 19:04