26781[BUGFIX] Display detected fatal in extension check
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Stefan Neufeind +1
- Thomas Maroschik +1
- Markus Klein +1
- Wouter Wolters +1
- Anja Leichsenring +1
- Helmut Hummel +1
-
Verified V +2
- Christian Kuhn +2
- Wouter Wolters +1
- Anja Leichsenring +1
- Helmut Hummel +1
Files 5
- typo3/sysext/install/Classes/Controller/Action/AbstractAction.php+15 −0
- typo3/sysext/install/Classes/Controller/Action/ActionInterface.php+7 −0
- typo3/sysext/install/Classes/Controller/ToolController.php3+24 −0
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/ImportantActions/LastError.htmlnew+12 −0
- typo3/sysext/install/Resources/Private/Templates/Action/Tool/LoadExtensions.html+2 −0
Review log 24
-
Markus Klein commented on patch set 1 01/13/14, 11:30
-
Thomas Maroschik uploaded patch set 2 01/13/14, 11:34
-
Thomas Maroschik commented on patch set 1 01/13/14, 11:34
ToolController.php:172ReplyDone -
Markus Klein voted on patch set 2 CR +1 01/13/14, 11:43
-
Wouter Wolters voted on patch set 2 CR +1 01/13/14, 11:48
-
Mr. Jenkins commented on patch set 1 CR -1 V -1 01/13/14, 11:54
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/12938/ : FAILURE -
Mr. Jenkins commented on patch set 2 01/13/14, 12:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12939/ : SUCCESS -
Stefan Neufeind voted on patch set 2 CR +1 01/16/14, 22:56
-
Anja Leichsenring voted on patch set 2 V +1 CR +1 01/29/14, 10:48
-
Helmut Hummel commented on patch set 2 01/29/14, 11:06
ToolController.php:136I would find it nicer, if we could store this in the session (if that is possible) Passing it by GET offers so many possibilities to abuse/attack -
Christian Kuhn commented on patch set 2 01/29/14, 11:12
nice. will review this evening. -
Helmut Hummel uploaded patch set 3 01/29/14, 12:35
-
Helmut Hummel voted on patch set 3 V +1 CR +1 01/29/14, 12:36
-
Thomas Maroschik voted on patch set 3 CR +1 01/29/14, 12:40
-
Wouter Wolters voted on patch set 3 CR +1 01/29/14, 12:42
-
Mr. Jenkins commented on patch set 3 01/29/14, 12:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13315/ : SUCCESS -
Stefan Neufeind voted on patch set 3 CR +1 01/29/14, 13:09
-
Markus Klein voted on patch set 3 CR +1 01/29/14, 14:55
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 01/29/14, 15:50
-
Wouter Wolters commented on patch set 3 V +1 01/29/14, 18:16
Christian announced to also have a look. Will contact him. -
Wouter Wolters wrote 01/29/14, 18:17
Topic set to "install-tool". -
Christian Kuhn commented on patch set 3 01/29/14, 18:42
I'll give it a shot now. -
Christian Kuhn commented on patch set 3 V +2 CR +2 01/29/14, 19:04
good! thx! -
Christian Kuhn merged patch set 4 01/29/14, 19:04
ToolController.php:172