26785[BUGFIX] TSFE->altPageTitle can not be set in extensions
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Stefan Neufeind +1
- Alexander Opitz +1
- Xavier Perseguers +1
- Bill Dagou +1
-
Verified V +2
- Wouter Wolters +2
- Alexander Opitz +1
Issues 1
Files 4
Review log 32
Show 7 earlier messages
-
Mr. Jenkins commented on patch set 1 01/13/14, 15:50
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12949/ : SUCCESS -
Oliver Klee commented on patch set 1 01/13/14, 16:44
PageGenerator.php:1098While you're refactoring this anyway, could you move the magic number 2 to a well-named class constant? -
Markus Klein uploaded patch set 2 01/13/14, 17:58
-
Markus Klein commented on patch set 1 01/13/14, 17:59
PageGenerator.php:1098ReplyDone -
Markus Klein commented on patch set 2 01/13/14, 17:59
PageGenerator.php:46Do we CGL that this needs to be uppercase? (I don't know by heart) -
Mr. Jenkins commented on patch set 2 01/13/14, 18:11
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12955/ : SUCCESS -
Oliver Klee commented on patch set 2 01/13/14, 21:43
PageGenerator.php:46ReplyYes, constants are all uppercase with underscores as word separators.
-
Markus Klein uploaded patch set 3 01/13/14, 22:16
-
Markus Klein uploaded patch set 4 01/13/14, 22:17
-
Wouter Wolters voted on patch set 4 CR +1 01/13/14, 22:20
-
Mr. Jenkins commented on patch set 3 01/13/14, 22:28
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12965/ : SUCCESS -
Mr. Jenkins commented on patch set 4 01/13/14, 22:30
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12966/ : SUCCESS -
Bill Dagou voted on patch set 4 V +1 CR +1 01/24/14, 07:44
-
Alexander Opitz voted on patch set 4 CR +1 01/24/14, 08:08
-
Wouter Wolters commented on patch set 4 01/27/14, 21:32
PageGenerator.php:1093tab -> space -
Markus Klein uploaded patch set 5 01/27/14, 21:54
-
Wouter Wolters voted on patch set 5 CR +1 01/27/14, 21:59
-
Mr. Jenkins commented on patch set 5 01/27/14, 22:21
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13249/ : SUCCESS -
Bill Dagou voted on patch set 5 CR +1 01/28/14, 01:08
-
Alexander Opitz voted on patch set 5 V +1 CR +1 01/28/14, 07:13
-
Wouter Wolters commented on patch set 5 V -1 01/28/14, 16:34
Unit-test fails TYPO3\CMS\Frontend\Tests\Unit\Controller\TypoScriptFrontendControllerTest::headerAndFooterMarkersAreReplacedDuringIntProcessing -
Markus Klein uploaded patch set 6 01/28/14, 19:31
-
Markus Klein commented on patch set 6 01/28/14, 19:32
Just moved the new call into a separate (non-static) function in order to make the call mockable -
Markus Klein commented on patch set 6 01/28/14, 19:40
couldn't run the functional tests due to system issues -
Mr. Jenkins commented on patch set 6 01/28/14, 19:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13283/ : SUCCESS -
Wouter Wolters commented on patch set 6 V +1 CR +1 01/28/14, 21:21
Unit-tests works again. -
Stefan Neufeind voted on patch set 6 CR +1 01/28/14, 23:28
-
Alexander Opitz voted on patch set 6 V +1 CR +1 01/29/14, 07:08
-
Xavier Perseguers voted on patch set 6 CR +1 01/29/14, 07:51
-
Bill Dagou voted on patch set 6 CR +1 01/29/14, 08:15
-
Wouter Wolters voted on patch set 6 V +2 CR +2 01/29/14, 19:42
-
Wouter Wolters merged patch set 7 01/29/14, 19:42