Review main Merged

26785[BUGFIX] TSFE->altPageTitle can not be set in extensions

Markus Klein CR +2 V +2 Normal +47 −10 updated 01/29/14, 19:42

Commit message

It is not possible to set $GLOBALS['TSFE']->altPageTitle
in USER_INT extensions anymore to modify the page title.

This has been possible before in the 4.x branches.

Fix this by implementing the title generation like all
other header data.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
    • Alexander Opitz +1
    • Xavier Perseguers +1
    • Bill Dagou +1
  • Verified V +2
    • Wouter Wolters +2
    • Alexander Opitz +1

Issues 1

Files 4

Review log 32

Show 7 earlier messages
  1. Mr. Jenkins commented on patch set 1 01/13/14, 15:50

  2. Oliver Klee commented on patch set 1 01/13/14, 16:44

    PageGenerator.php:1098

    While you're refactoring this anyway, could you move the magic number 2 to a well-named class constant?
  3. Markus Klein uploaded patch set 2 01/13/14, 17:58

  4. Markus Klein commented on patch set 1 01/13/14, 17:59

    PageGenerator.php:1098 Reply

    Done
  5. Markus Klein commented on patch set 2 01/13/14, 17:59

    PageGenerator.php:46

    Do we CGL that this needs to be uppercase? (I don't know by heart)
  6. Mr. Jenkins commented on patch set 2 01/13/14, 18:11

  7. Oliver Klee commented on patch set 2 01/13/14, 21:43

    PageGenerator.php:46 Reply

    Yes, constants are all uppercase with underscores as word separators.
  1. Markus Klein uploaded patch set 3 01/13/14, 22:16

  2. Markus Klein uploaded patch set 4 01/13/14, 22:17

  3. Wouter Wolters voted on patch set 4 CR +1 01/13/14, 22:20

  4. Mr. Jenkins commented on patch set 3 01/13/14, 22:28

  5. Mr. Jenkins commented on patch set 4 01/13/14, 22:30

  6. Bill Dagou voted on patch set 4 V +1 CR +1 01/24/14, 07:44

  7. Alexander Opitz voted on patch set 4 CR +1 01/24/14, 08:08

  8. Wouter Wolters commented on patch set 4 01/27/14, 21:32

    PageGenerator.php:1093

    tab -> space
  9. Markus Klein uploaded patch set 5 01/27/14, 21:54

  10. Wouter Wolters voted on patch set 5 CR +1 01/27/14, 21:59

  11. Mr. Jenkins commented on patch set 5 01/27/14, 22:21

  12. Bill Dagou voted on patch set 5 CR +1 01/28/14, 01:08

  13. Alexander Opitz voted on patch set 5 V +1 CR +1 01/28/14, 07:13

  14. Wouter Wolters commented on patch set 5 V -1 01/28/14, 16:34

    Unit-test fails TYPO3\CMS\Frontend\Tests\Unit\Controller\TypoScriptFrontendControllerTest::headerAndFooterMarkersAreReplacedDuringIntProcessing
  15. Markus Klein uploaded patch set 6 01/28/14, 19:31

  16. Markus Klein commented on patch set 6 01/28/14, 19:32

    Just moved the new call into a separate (non-static) function in order to make the call mockable
  17. Markus Klein commented on patch set 6 01/28/14, 19:40

    couldn't run the functional tests due to system issues
  18. Mr. Jenkins commented on patch set 6 01/28/14, 19:46

  19. Wouter Wolters commented on patch set 6 V +1 CR +1 01/28/14, 21:21

    Unit-tests works again.
  20. Stefan Neufeind voted on patch set 6 CR +1 01/28/14, 23:28

  21. Alexander Opitz voted on patch set 6 V +1 CR +1 01/29/14, 07:08

  22. Xavier Perseguers voted on patch set 6 CR +1 01/29/14, 07:51

  23. Bill Dagou voted on patch set 6 CR +1 01/29/14, 08:15

  24. Wouter Wolters voted on patch set 6 V +2 CR +2 01/29/14, 19:42

  25. Wouter Wolters merged patch set 7 01/29/14, 19:42