26787[TASK] Speedup typolink root-line handling
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
- Helmut Hummel +2
- Jo Hasenau +1
- Markus Klein +1
-
Verified V +2
- Oliver Hader +2
- Markus Klein +1
Issues 1
Files 2
Review log 25
-
Mr. Jenkins commented on patch set 1 01/13/14, 18:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12956/ : SUCCESS -
Markus Klein commented on patch set 1 01/13/14, 18:27
RootlineUtility.php:198Proposal: invert the condition and the bodies. saves one ! and is more logical to read IMO.RootlineUtility.php:206Please add a comment here what this magic actually does. ;-) Can't we use a simple for loop here? -
Benni Mack commented on patch set 1 V +1 CR +1 01/13/14, 18:50
Speeds up un-cached pages immensly. -
Oliver Klee commented on patch set 1 01/13/14, 21:54
TypoScriptFrontendController.php:4923I'd prefer a field in the class instead. static local variables are impossible to mock in unit tests. -
Helmut Hummel commented on patch set 1 01/14/14, 06:40
TypoScriptFrontendController.php:4923ReplyAnd this actually is a rootline cache not a domain cache -
Steffen Ritter commented on patch set 1 01/14/14, 08:28
TypoScriptFrontendController.php:4923Replyhmm... the function retrieves DomainData for every PID - (which indeed is generated by combining rootline and domain info) - the result is cached... so either the function name does not describe what it does or it is a domainData cache ;) -
Helmut Hummel commented on patch set 1 01/14/14, 12:38
TypoScriptFrontendController.php:4923Replyah, right, sry -
Oliver Hader commented on patch set 1 V -1 01/14/14, 13:45
Failure in front-end... -
Oliver Hader uploaded patch set 2 01/14/14, 13:55
-
Mr. Jenkins commented on patch set 2 01/14/14, 14:11
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12979/ : SUCCESS -
Oliver Hader uploaded patch set 3 01/14/14, 14:20
-
Oliver Hader commented on patch set 3 V +1 CR +1 01/14/14, 14:22
Implemented Markus' remarks -
Jo Hasenau commented on patch set 3 01/14/14, 14:26
There's some more reduncdancy to get rid of - see comment.RootlineUtility.php:210Shouldn't this one check for existing cache identifiers for that particular UID first and do a break as soon as it hits one? -
Mr. Jenkins commented on patch set 3 01/14/14, 14:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12980/ : SUCCESS -
Oliver Hader uploaded patch set 4 01/14/14, 14:47
-
Jo Hasenau voted on patch set 4 CR +1 01/14/14, 14:49
-
Oliver Hader voted on patch set 4 V +1 CR +1 01/14/14, 14:54
-
Mr. Jenkins commented on patch set 4 01/14/14, 15:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12981/ : SUCCESS -
Markus Klein commented on patch set 4 CR +1 01/14/14, 15:48
RootlineUtility.php:205Still I'd prefer a for loop here, but ok with me. for ($depth = count($entry) - 2; $depth > 0; --$depth) { $parentCacheIdentifier = $this->getCacheIdentifier($entry[$depth]['uid']); ... } -
Markus Klein commented on patch set 4 01/14/14, 17:03
TypoScriptFrontendController.php:4929This function is ONLY used if config.typolinkEnableLinksAcrossDomains or config.typolinkCheckRootline is set. -
Markus Klein voted on patch set 4 V +1 01/14/14, 17:23
-
Helmut Hummel voted on patch set 4 CR +2 01/14/14, 17:47
-
Oliver Hader voted on patch set 4 V +2 CR +2 01/14/14, 17:48
-
Helmut Hummel merged patch set 5 01/14/14, 17:48
-
Helmut Hummel commented on patch set 5 01/14/14, 17:49
Cherry Picked This patchset was cherry picked to change: Iea7fff4c6c624a03b75523a7352b5f9736f2d57e