Review main Merged

26831[BUGFIX] Filelist translations does not consider BE user access rights

Benni Mack CR +2 V +2 Easy +14 −8 updated 01/31/14, 08:05

Commit message

If a BE editor has only access to sys_language uid 2 and 3
but not 1, it is not respected in the file list module,
as the BE user can see all flags.

The attached patch filters all inaccessible translation records.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Wouter Wolters +1
    • Stefan Froemken +1
  • Verified V +2
    • Steffen Ritter +2
    • Stefan Froemken +1

Issues 1

Files 1

Review log 20

  1. Steffen Ritter voted on patch set 1 CR +1 01/15/14, 11:22

  2. Steffen Ritter wrote 01/15/14, 11:22

    Topic set to "fal".
  3. Mr. Jenkins commented on patch set 1 01/15/14, 11:33

  4. Benni Mack uploaded patch set 2 01/15/14, 13:13

  5. Mr. Jenkins commented on patch set 2 01/15/14, 13:26

  6. Wouter Wolters voted on patch set 2 CR +1 01/15/14, 18:16

  7. Steffen Ritter voted on patch set 2 V +1 01/21/14, 06:43

  8. Steffen Ritter voted on patch set 2 CR +2 01/21/14, 06:44

  9. Stefan Neufeind voted on patch set 2 CR +1 01/21/14, 23:25

  10. Oliver Klee commented on patch set 2 01/22/14, 10:38

    FileList.php:608

    Can we use strict comparisons here? (===)

    FileList.php:684

    Faster: if (!empty($systemLanguages))
  11. Stefan Froemken uploaded patch set 3 01/30/14, 18:53

  12. Stefan Froemken uploaded patch set 4 01/30/14, 18:54

  13. Stefan Froemken uploaded patch set 5 01/30/14, 19:01

  14. Stefan Froemken commented on patch set 5 V +1 CR +1 01/30/14, 19:03

    I have only applied the comments
  15. Wouter Wolters voted on patch set 5 CR +1 01/30/14, 20:43

  16. Mr. Jenkins commented on patch set 3 01/30/14, 22:37

  17. Mr. Jenkins commented on patch set 4 01/30/14, 22:50

  18. Mr. Jenkins commented on patch set 5 01/30/14, 22:52

  19. Steffen Ritter voted on patch set 5 V +2 CR +2 01/31/14, 08:05

  20. Steffen Ritter merged patch set 6 01/31/14, 08:05