Review main Merged

26842[TASK] Extend TypoScriptParser test cases

Oliver Hader CR +2 V +2 Normal +104 −0 updated 01/15/14, 15:12

Commit message

Review

  • Code review CR +2
    • Oliver Hader +2
    • Oliver Klee +1
  • Verified V +2
    • Oliver Hader +2

Issues 1

Files 1

Review log 6

  1. Mr. Jenkins commented on patch set 1 01/15/14, 14:52

  2. Oliver Klee commented on patch set 1 CR +1 01/15/14, 14:57

    TypoScriptParserTest.php:384

    You can use the TAB constant here.
  3. Oliver Hader voted on patch set 1 V +2 CR +2 01/15/14, 15:06

  4. Oliver Hader merged patch set 2 01/15/14, 15:06

  5. Oliver Hader commented on patch set 2 01/15/14, 15:06

    Oh sorry, just realized your additional comment... hope it's still fine with you
  6. Oliver Klee commented on patch set 2 01/15/14, 15:12

    Yes, this was no blocker, just a suggestion for have cleaner code. So it's okay for me. :-)