Review main Merged

26872[TASK] Use file_exists() instead of is_file()

Oliver Hader CR +2 V +2 Easy +9 −9 updated 01/16/14, 12:12

Commit message

is_file() checks whether a resource exists and whether it
is actually a file. There are several parts in the core,
where it is sufficient to check for the existence only,
which is faster.

Review

  • Code review CR +2
    • Benni Mack +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Tom +1
  • Verified V +2
    • Benni Mack +2
    • Tom +1

Issues 1

Files 3

Review log 7

  1. Oliver Hader commented on patch set 1 01/16/14, 11:16

    Please feel free to modify this change and please test it a lot... maybe it turns out, that at some places is_file() is still required, instead of using file_exists()
  2. Mr. Jenkins commented on patch set 1 01/16/14, 11:28

  3. Wouter Wolters voted on patch set 1 CR +1 01/16/14, 11:29

  4. Tom voted on patch set 1 V +1 CR +1 01/16/14, 11:58

  5. Oliver Klee voted on patch set 1 CR +1 01/16/14, 11:58

  6. Benni Mack voted on patch set 1 V +2 CR +2 01/16/14, 12:12

  7. Benni Mack merged patch set 2 01/16/14, 12:12