Review main Merged

26895[BUGFIX] Simulate time in TYPO3 admin panel broken

Peter Niederlag CR +2 V +2 Easy +22 −1 updated 01/06/19, 11:15

Commit message

* Test typeof TBE_EDITOR == "undefined" in jsfunc.evalfield
* Thanks to Stefan Neufeind/Markus Klein for adding the Unittest

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Wouter Wolters +1
    • Markus Klein +1
    • Henrik Ziegenhain +1
  • Verified V +2
    • Stefan Neufeind +2
    • Markus Klein +1
    • Henrik Ziegenhain +1

Issues 1

Files 2

Review log 25

  1. Peter Niederlag uploaded patch set 2 01/17/14, 10:35

  2. Peter Niederlag commented on patch set 2 01/17/14, 10:36

    see patch set 1 for debugging of #55093 and #23935
  3. Markus Klein commented on patch set 2 CR +1 01/17/14, 10:38

    Simon Lang?? Stefan Neufeind added the test here: https://review.typo3.org/#/c/23094/2/typo3/sysext/frontend/Tests/Unit/View/AdminPanelViewTest.php And I improved it a set later.... Just for the sake of correctness
  4. Mr. Jenkins commented on patch set 1 CR -1 V -1 01/17/14, 10:41

  5. Peter Niederlag uploaded patch set 3 01/17/14, 10:43

  6. Markus Klein commented on patch set 3 V +1 CR +1 01/17/14, 10:45

    Thanks for adding us. I rather thought we don't need to quote ourselves. ;-)
  7. Markus Klein commented on patch set 3 V 0 01/17/14, 10:47

    removing my verified till I ran the unittests again
  8. Peter Niederlag commented on patch set 3 01/17/14, 10:49

    failure is on patch set 1 due to the (intentional) debugs, that I didn't check. ;( I thought it might be a wise idea to add a first patch set with demo/debug code. maybe it's not. ;(
  9. Markus Klein voted on patch set 3 V +1 01/17/14, 10:50

  10. Mr. Jenkins commented on patch set 2 01/17/14, 10:56

  11. Mr. Jenkins commented on patch set 3 01/17/14, 10:58

  12. Wouter Wolters updated the commit message in patch set 3 01/17/14, 11:01

  13. Wouter Wolters voted on patch set 4 CR +1 01/17/14, 11:01

  14. Mr. Jenkins commented on patch set 4 01/17/14, 11:15

  15. Markus Klein commented on patch set 4 V +1 CR +1 01/20/14, 12:16

    Shouldn't we backport this?
  16. Stefan Neufeind commented on patch set 4 01/20/14, 12:17

    Reply

    if it's broken and now we unbreak it, imho yes :-)
  17. Markus Klein updated the commit message in patch set 4 01/21/14, 11:08

  18. Markus Klein voted on patch set 5 V +1 CR +1 01/21/14, 11:09

  19. Markus Klein commented on patch set 5 01/21/14, 11:09

    Added the backports to the commit message
  20. Mr. Jenkins commented on patch set 5 01/21/14, 11:28

  21. Wouter Wolters voted on patch set 5 CR +1 01/21/14, 11:36

  22. Stefan Neufeind voted on patch set 5 V +2 CR +2 01/21/14, 22:48

  23. Stefan Neufeind merged patch set 6 01/21/14, 22:48

  24. Henrik Ziegenhain voted on patch set 4 V +1 CR +1 01/06/19, 11:15

  25. Henrik Ziegenhain commented on patch set 5 V +1 CR +1 01/06/19, 11:15

    Thanks for adjusting the Releases.