Review main Merged

26906[TASK] Remove fixed width for Content Element Wizard tabs content container

Marcin Sągol CR +2 V +2 Easy +0 −5 updated 01/17/14, 17:13

Commit message

When using Content Element Wizard configured to render items with
tabs their body container has fixed width of 680px. This leads
to visual problems when using some extra tabs registered - their
titles are rendered outside body content. This patch removes
fixed width and some other styles that are not needed. For example
there are some styles for tables inside tab content but items are
rendered in lists not tables so we can remove them.

Review

  • Code review CR +2
    • Ernesto Baschny +2
    • Markus Klein +1
    • Marcin Sągol +1
  • Verified V +2
    • Ernesto Baschny +2
    • Markus Klein +1
    • Marcin Sągol +1

Issues 1

Files 1

Review log 9

  1. Markus Klein commented on patch set 1 01/17/14, 16:55

    - their titles are ...
  2. Ernesto Baschny commented on patch set 1 V +1 CR +1 01/17/14, 16:55

    I had this exact change laying around here, now I recognized it again. It works, and solves the problem, thanks! This hardcoded CSS is useless for ages already...
  3. Marcin Sągol uploaded patch set 2 01/17/14, 17:00

  4. Markus Klein voted on patch set 2 V +1 CR +1 01/17/14, 17:01

  5. Marcin Sągol voted on patch set 2 V +1 CR +1 01/17/14, 17:03

  6. Ernesto Baschny voted on patch set 2 V +2 CR +2 01/17/14, 17:05

  7. Ernesto Baschny merged patch set 3 01/17/14, 17:05

  8. Mr. Jenkins commented on patch set 1 01/17/14, 17:06

  9. Mr. Jenkins commented on patch set 2 01/17/14, 17:13