Review main Merged

26925[BUGFIX] Flow\Utility\Exception missing

Philipp Gampe CR +2 V +2 Easy +22 −0 updated 01/20/14, 08:44

Commit message

This exception is required by PackageManager

Review

  • Code review CR +2
    • Philipp Gampe +2
    • Oliver Klee +1
    • Wouter Wolters +1
  • Verified V +2
    • Philipp Gampe +2
    • Wouter Wolters +1

Issues 1

Files 2

Review log 26

Show 1 earlier messages
  1. Philipp Gampe voted on patch set 1 CR -1 01/18/14, 16:46

  1. Philipp Gampe uploaded patch set 2 01/18/14, 16:47

  2. Philipp Gampe uploaded patch set 3 01/18/14, 16:49

  3. Mr. Jenkins commented on patch set 1 01/18/14, 17:00

  4. Mr. Jenkins commented on patch set 2 01/18/14, 17:04

  5. Oliver Klee voted on patch set 3 CR +1 01/18/14, 17:05

  6. Mr. Jenkins commented on patch set 3 01/18/14, 17:16

  7. Marcin Sągol commented on patch set 3 01/18/14, 21:22

    ext_autoload.php:47

    Before Exception.php backslash is used "\" - shouldn't be slash "/" ?
  8. Philipp Gampe uploaded patch set 4 01/18/14, 21:32

  9. Philipp Gampe commented on patch set 3 01/18/14, 21:32

    funny that it worked

    ext_autoload.php:47 Reply

    Done
  10. Oliver Klee commented on patch set 4 CR +1 01/18/14, 21:37

    Maybe the buggy version worked only on windows.
  11. Mr. Jenkins commented on patch set 4 01/18/14, 21:45

  12. Philipp Gampe commented on patch set 4 01/18/14, 21:46

    Nope ... it is fixed by the core class loader in line 231. I always use Linux unless forced otherwise :D
  13. Marcin Sągol voted on patch set 4 V +1 CR +1 01/18/14, 21:49

  14. Markus Klein voted on patch set 4 CR +1 01/19/14, 12:43

  15. Markus Klein commented on patch set 4 CR -1 01/19/14, 12:57

    Nope, please do not move the exception, but implement the one from Flow properly
  16. Markus Klein uploaded patch set 5 01/19/14, 13:00

  17. Markus Klein uploaded patch set 6 01/19/14, 13:01

  18. Mr. Jenkins commented on patch set 5 01/19/14, 13:15

  19. Oliver Klee voted on patch set 6 CR +1 01/19/14, 13:49

  20. Wouter Wolters voted on patch set 6 V +1 CR +1 01/19/14, 17:25

  21. Philipp Gampe commented on patch set 6 01/19/14, 17:53

    Are you sure this is the right way to go? The other exception is not used and the readme file states that it was extending the CMS Exception calls on purpose.
  22. Markus Klein commented on patch set 6 01/19/14, 19:22

    It still does extend the Core Exception, but via the Flow Exception
  23. Markus Klein commented on patch set 6 01/19/14, 19:22

    And now the other Exception is used by this one.
  24. Philipp Gampe commented on patch set 6 V +2 CR +2 01/20/14, 08:44

    Thanks, I overlooked that part. As you rewrote the patch completely, I take the freedom to merge it.
  25. Philipp Gampe merged patch set 7 01/20/14, 08:44