Review main Merged

26928[TASK] Remove find file in EXT: lowlevel

Felix Kopp CR +2 V +2 Normal +5 −71 updated 01/28/14, 16:19

Commit message

Removes the find file function from EXT: lowlevel.
Find file was only available for admins.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Oliver Klee +1
    • Ernesto Baschny +1
  • Verified V +2
    • Wouter Wolters +2
    • Ernesto Baschny +1

Issues 1

Files 1

Review log 11

  1. Philipp Gampe commented on patch set 1 01/18/14, 17:44

    why?
  2. Mr. Jenkins commented on patch set 1 01/18/14, 17:56

  3. Oliver Klee voted on patch set 1 CR +1 01/18/14, 18:54

  4. Marcin Sągol commented on patch set 1 01/20/14, 15:22

    What about the labels used here - they should stay in language file?
  5. Marcin Sągol commented on patch set 1 01/20/14, 15:27

    Also i would like to hear answer for Philipps question :)
  6. Felix Kopp commented on patch set 1 01/20/14, 15:40

    Tool is only available for admins and not sufficient. Admins can browse files on the server more conveniently via real admin tool. Labels always have to stay since the XLIF files are used over several versions.
  7. Felix Kopp commented on patch set 1 01/20/14, 15:40

    -> Please also see the Invision document
  8. Ernesto Baschny commented on patch set 1 V +1 CR +1 01/27/14, 20:57

    This is part of a usability cleanup in the backend (of course just a tiny part of it). See: https://projects.invisionapp.com/share/H2IU7YVE#/screens/10259995/comments/6169346 The functionality is very limited, unintuitive, incomplete and misplaced (finding files in "DB Check"?) would need core maintenance, security considerations and usability improvements to be really useful in a professional product. Such a feature is very seldom needed and can be best addressed by a much more complete third party extension. This is why we decided to remove it instead of improving (or replacing it).
  9. Wouter Wolters commented on patch set 1 V +2 CR +2 01/27/14, 21:03

    Will wait 48h before merging to let people react in Forge or here
  10. Wouter Wolters commented on patch set 1 01/28/14, 16:19

    Got feedback in Forge
  11. Wouter Wolters merged patch set 2 01/28/14, 16:19