Review main Merged

26936[TASK] Remove unneeded padding in page module

Georg Ringer CR +2 V +2 Easy +26 −19 updated 02/02/14, 20:22

Commit message

Removes excessive top margin above Web>Page backend layout
cells. Brings gridCells equal heights and bottom spacing. Replaces
full white borders with adequate margins.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Benni Mack +1
  • Verified V +2
    • Wouter Wolters +2
    • Benni Mack +1

Issues 2

Files 2

Review log 7

  1. Mr. Jenkins commented on patch set 1 01/20/14, 06:48

  2. Felix Kopp commented on patch set 1 01/20/14, 11:40

    module_web_page.css:120

    I think the padding must be to the bottom then. See http://forge.typo3.org/issues/39971. Cheers
  3. Felix Kopp uploaded patch set 2 02/02/14, 12:48

  4. Benni Mack voted on patch set 2 V +1 CR +1 02/02/14, 14:12

  5. Wouter Wolters voted on patch set 2 V +2 CR +2 02/02/14, 16:35

  6. Wouter Wolters merged patch set 3 02/02/14, 16:35

  7. Mr. Jenkins commented on patch set 2 02/02/14, 20:22