26981[BUGFIX] Flush caches in group should throw exception
Commit message
Review
-
Code review CR +2
- Felix Oertel +2
- Anja Leichsenring +1
-
Verified V +2
- Felix Oertel +2
- Anja Leichsenring +1
Issues 1
Files 3
Review log 27
Show 2 earlier messages
-
Helmut Hummel updated the commit message in patch set 2 02/03/14, 18:49
-
Mr. Jenkins commented on patch set 2 02/03/14, 20:10
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13663/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13662/ : SUCCESS -
Mr. Jenkins commented on patch set 3 02/03/14, 20:24
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13664/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13663/ : SUCCESS -
Dmitry Dulepov commented on patch set 3 CR -1 02/18/14, 13:04
Missing description. Missing bug tracker issue id. -
Wouter Wolters commented on patch set 3 02/18/14, 13:24
As the commit message describes this is a WIP = Work In Progress :-) So nothing here to review yet -
Dmitry Dulepov commented on patch set 3 02/25/14, 12:53
Hm, why is it pushed to the *review* server if there is nothing for review yet? :) I guess, it should be in the incubator or in the local repo? -
Wouter Wolters commented on patch set 3 02/25/14, 12:58
To make other contributors aware that you (the creator of the patch) are working on something they might be interested in or would have started to work on by them selfs. This is normal procedure since I'm a contributor:-) -
Helmut Hummel uploaded patch set 4 05/03/14, 19:01
-
Mr. Jenkins commented on patch set 4 05/03/14, 22:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16251/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/16247/ : SUCCESS -
Philipp Gampe voted on patch set 4 CR +1 05/04/14, 08:01
-
Christian Kuhn commented on patch set 4 05/04/14, 08:08
sounds reasonable to me, did not test yet.CacheManager.php:182I'd prefer an own exception here (NoSuchCacheGroupException or similar) to not misuse this exception. This would be nicer as long as we are not forced to then manually require this new exception in early bootstrap calls, imho. -
Felix Oertel uploaded patch set 5 05/04/14, 08:41
-
Felix Oertel commented on patch set 5 05/04/14, 08:41
Awwww ... messed up the dependency, sorry. -
Felix Oertel uploaded patch set 6 05/04/14, 08:42
-
Felix Oertel commented on patch set 6 V +2 CR +2 05/04/14, 08:43
Pro Exception, works for me. @lolli Where could the bootstrap raise problems? Require was not needed for normal frontend, backend, cli and tests ... -
Christian Kuhn voted on patch set 6 CR +1 05/04/14, 08:47
-
Mr. Jenkins commented on patch set 5 05/04/14, 08:58
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16263/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/16259/ : SUCCESS -
Andreas Wolf uploaded patch set 7 05/04/14, 09:00
-
Mr. Jenkins commented on patch set 6 05/04/14, 09:17
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16264/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/16260/ : SUCCESS -
Andreas Wolf uploaded patch set 8 05/04/14, 09:47
-
Anja Leichsenring voted on patch set 8 V +1 CR +1 05/04/14, 10:13
-
Felix Oertel voted on patch set 8 V +2 CR +2 05/04/14, 10:15
-
Felix Oertel merged patch set 9 05/04/14, 10:15
-
Mr. Jenkins commented on patch set 7 05/04/14, 16:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16270/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/16266/ : SUCCESS -
Mr. Jenkins commented on patch set 8 05/04/14, 18:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16279/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/16275/ : SUCCESS