26999[BUGFIX] Invalid class name to file path conversion
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
- Stefan Neufeind +1
- Markus Klein +1
- Marcin Sągol +1
-
Verified V +2
- Xavier Perseguers +2
- Markus Klein +1
- Marcin Sągol +1
Files 1
Review log 15
-
Mr. Jenkins commented on patch set 1 01/22/14, 17:40
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13166/ : SUCCESS -
Markus Klein commented on patch set 1 01/22/14, 18:53
ClassLoader.php:338Why translating the string again? $classNameWithoutVendorAndProduct = strtr(ucwords(strtr($classNameWithoutVendorAndProduct, $delimiter, LF)), LF, '/'); $classFilePath = $classesPath . $classNameWithoutVendorAndProduct . '.php'; -
Xavier Perseguers commented on patch set 1 01/22/14, 18:59
ClassLoader.php:338Replyyou're right ;) -
Xavier Perseguers uploaded patch set 2 01/22/14, 19:02
-
Markus Klein commented on patch set 2 CR +1 01/22/14, 19:03
How to verify? -
Xavier Perseguers commented on patch set 2 01/22/14, 19:14
2 ways: on case sensitive filesystem, you should not see the cache for the corresponding class because it was wrongly computed, on case insensitive you had it but if you read it (typo3temp/Cache/Data/cache_classes/<classname> you'll see the path is obviously wrong. There are numerous articles on the internet telling that PHP fatals if you autoload a class (using proper file name) and do it again with a require that is the wrong file name since the path is not the same, it's not seen as already there. In my case, I have an Extbase extension with parent->child relations, IRRE, ... and while switching from a generic list to a details view with all children "resolved" and shown, I get this error as Extbase wants to convert the table name tx_extension_domain_model_whatever to the corresponding class name to populate the domain model and it hits the wrong cache entry, thus PHP fatals -
Mr. Jenkins commented on patch set 2 01/22/14, 19:15
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13169/ : SUCCESS -
Markus Klein voted on patch set 2 V +1 01/22/14, 20:03
-
Marcin Sągol voted on patch set 2 CR +1 01/22/14, 20:08
-
Stefan Neufeind commented on patch set 2 CR +1 01/22/14, 23:50
And 6.1/6.0? Or do you fear that would be "breaking"? -
Xavier Perseguers commented on patch set 2 01/23/14, 15:46
Reply
Did not have problem with 6.1, it's really after switching to 6.2 that problem appeared -
Markus Klein commented on patch set 2 01/23/14, 16:01
Reply
Classloader has been modified heavily in 6.2. Therefore I'm sure it only appies to 6.2 -
Marcin Sągol voted on patch set 2 V +1 01/23/14, 16:15
-
Xavier Perseguers voted on patch set 2 V +2 CR +2 01/25/14, 15:46
-
Xavier Perseguers merged patch set 3 01/25/14, 15:46