27021[BUGFIX] filterForStringReturnsStringWithUppercasedWords' breaks ß
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 12
-
Mr. Jenkins commented on patch set 1 01/23/14, 11:11
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13177/ : SUCCESS -
Markus Klein commented on patch set 1 CR -1 01/23/14, 16:21
mbstring is NOT required for 6.2 Isn't there somewhere a function to do this in the charset conversion classes? -
Christian Kuhn commented on patch set 1 CR -1 01/29/14, 20:03
+1 to Markus, I think this should be solved with the charset api (but i did not look at it) since mbstring is not a hard requirement. -
Markus Klein commented on patch set 1 03/26/14, 21:21
Stefano, please fix that -
Stefan Neufeind uploaded patch set 2 04/18/14, 23:23
-
Stefan Neufeind commented on patch set 2 04/18/14, 23:25
ucwords imho needs to be utf8-aware as well. But conv_case currently can't help here. Extend conv_case in a separate patchset first? -
Mr. Jenkins commented on patch set 2 04/18/14, 23:37
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16071/ : SUCCESS -
Michael Oehlhof commented on patch set 2 12/13/14, 17:45
Can TitleCaseFilterTest.php be removed from the patch, because mb_internal_encoding should not be used? -
Mathias Schreiber wrote 12/17/14, 14:33
Topic set to EXT: form -
Christian Kuhn commented on patch set 2 CR -1 01/30/15, 19:07
Issue is probably still valid. Anyone wants to pick up again?TitleCaseFilter.php:41::class and maybe a use.TitleCaseFilterTest.php:44the "current" setting should be preserved somehow to not leave a changed environment behind. -
Steffen Müller commented on patch set 2 CR -1 01/31/15, 10:53
Seems this has been fixed already via #62279 - see http://review.typo3.org/33335 -
Steffen Müller abandoned the change 01/31/15, 10:55
Closed as duplicate of https://review.typo3.org/#/c/33335/