Review main Merged

27079[BUGFIX] Prevent strings from being autoloaded

Helmut Hummel CR +2 V +2 Easy +4 −7 updated 01/29/14, 10:30

Commit message

The introduction of a TypeConverter for Enumaration
types in #52762 added is_subclass() calls to
getPlainValue() in the DatabaseBackends. These methods
are meant to convert objects to simply types but are
regularly called with simple types, in particular strings.

Since is_subclass() also works with strings,
The class loader is triggered when these methods
are called with a table name like "tx_ext_domain_model_foo".

This triggers an issue #55418 in the class loader especially
on case insensitive filesystems.

Instead of is_subclass we now use instanceof to make sure
we only check for conversion if the value is an object.

Additionally this change fixes a wrong case statement which
also was introduced in #52762

Review

  • Code review CR +2
    • Helmut Hummel +2
  • Verified V +2
    • Helmut Hummel +2

Issues 1

Files 3

Review log 16

  1. Helmut Hummel uploaded patch set 2 01/27/14, 20:56

  2. Helmut Hummel uploaded patch set 3 01/27/14, 21:08

  3. Mr. Jenkins commented on patch set 1 01/27/14, 21:09

  4. Xavier Perseguers voted on patch set 3 V +1 CR +1 01/27/14, 21:11

  5. Mr. Jenkins commented on patch set 2 01/27/14, 21:38

  6. Mr. Jenkins commented on patch set 3 01/27/14, 21:50

  7. Helmut Hummel updated the commit message in patch set 3 01/28/14, 15:53

  8. Mr. Jenkins commented on patch set 4 01/28/14, 16:06

  9. Xavier Perseguers voted on patch set 4 V +1 CR +1 01/28/14, 16:11

  10. Stefan Froemken commented on patch set 4 V +1 CR +1 01/28/14, 17:31

    Works pretty good and there are no duplicated in classes_cache anymore. Thank you.
  11. Helmut Hummel updated the commit message in patch set 4 01/29/14, 10:10

  12. Helmut Hummel updated the commit message in patch set 5 01/29/14, 10:11

  13. Helmut Hummel commented on patch set 6 V +2 CR +2 01/29/14, 10:20

    Only changed commit message. Merging taking previous votes into account
  14. Helmut Hummel merged patch set 7 01/29/14, 10:20

  15. Mr. Jenkins commented on patch set 5 01/29/14, 10:30

  16. Mr. Jenkins commented on patch set 6 01/29/14, 10:30