Review main Merged

27107[TASK] Increase title column width in Web List module

Marcin Sągol CR +2 V +2 Easy +1 −1 updated 01/30/14, 17:06

Commit message

Each database table has configured title column through
TCA configuration. This values are used by List Module
to render first (title) column on records list table.

Long values are truncated to some predefined number of
characters but since we now use larger font size (12px
instead of 11px), long titles can break to two lines due
to a fixed 300px column size.

This change increases title column width to 350px to
cope with the increased font size.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Ernesto Baschny +1
  • Verified V +2
    • Christian Kuhn +2
    • Ernesto Baschny +1

Issues 1

Files 1

Review log 13

  1. Wouter Wolters updated the commit message in patch set 1 01/28/14, 22:05

  2. Mr. Jenkins commented on patch set 1 01/28/14, 22:13

  3. Mr. Jenkins commented on patch set 2 01/28/14, 22:27

  4. Ernesto Baschny uploaded patch set 3 01/29/14, 09:05

  5. Ernesto Baschny commented on patch set 3 V +1 CR +1 01/29/14, 09:06

    Good catch. Reason for this is the increased font-size (12px instead of 11px), which is why this now happens where it didn't happen before. 350px should be enough thou, proportionally to the font size increase.
  6. Mr. Jenkins commented on patch set 3 01/29/14, 09:17

  7. Marcin Sągol commented on patch set 3 01/29/14, 11:44

    I have few records now (after change to 350px) that take 2 lines. I think 360px or 370px should be enough.
  8. Marcin Sągol commented on patch set 3 01/29/14, 12:15

    Just tested it on a list with 300 records and second one with 100 records. The safe value is 380 px for me (tested on Kubuntu so the font rendering might be a little bit different than on Windows but not that much).
  9. Christian Kuhn voted on patch set 3 V +2 CR +2 01/29/14, 19:42

  10. Christian Kuhn merged patch set 4 01/29/14, 19:42

  11. Marcin Sągol commented on patch set 4 01/29/14, 19:49

    Hmm i think the size should be increased bit more as sugested in previous comments.
  12. Ernesto Baschny commented on patch set 4 01/30/14, 16:07

    could you share some screenshots please, Marcin?
  13. Marcin Sągol commented on patch set 4 01/30/14, 17:06

    Ernesto 350px width works in Firefox but not in Chrome/Chromium. The calculated width of this table cell is not the same in this browsers.