Review main Merged

27108[BUGFIX] Tame PackageStates.php in functional tests

Christian Kuhn CR +2 V +2 Normal +58 −15 updated 01/29/14, 18:47

Commit message

Functional test bootstrap creates a full new instance
within typo3temp together with an own database. Goal is
a controlled environment without dependencies to the
parent instance.

The patch introduces separation of PackageStates.php. The file
is now compiled based on a static list of active core extensions
and optional additional extensions for specific functional tests.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Thomas Maroschik +1
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 2

Review log 7

  1. Christian Kuhn commented on patch set 1 01/28/14, 23:19

    This fixed functional tests in my environment and executes successfully on travis-ci.
  2. Christian Kuhn uploaded patch set 2 01/28/14, 23:23

  3. Mr. Jenkins commented on patch set 2 01/28/14, 23:35

  4. Thomas Maroschik voted on patch set 2 CR +1 01/29/14, 07:22

  5. Wouter Wolters commented on patch set 2 V +1 CR +1 01/29/14, 07:45

    Thanks Christian! Functional tests are running again.
  6. Christian Kuhn commented on patch set 2 V +2 CR +2 01/29/14, 18:41

    Since this fixes a nifty issue in the functional testsuite and it also executed successfully in catharsis already, this is merged now.
  7. Christian Kuhn merged patch set 3 01/29/14, 18:41