Review main Merged

27111[TASK] Make files visible by default

Fabien Udriot CR +2 V +2 Easy +1 −1 updated 01/30/14, 12:53

Commit message

For FAL, the concept of "hidden" files was introduced with the sysext
"metadata". The field is called "visible", its usage is to be
implemented by the plugin.

The default value for visible is FALSE, making it error-prone for users
uploading new files: They are hidden by default, requiring additional
work by the end-user (or the plugin/backend module doing the work) to
un-hide the files.

This commit changes the default of ``sys_file_metadata:visible`` to
``1``, making *new* files visible by default.

Review

  • Code review CR +2
    • Andreas Wolf +2
  • Verified V +2
    • Andreas Wolf +2

Issues 1

Files 1

Review log 9

  1. Mr. Jenkins commented on patch set 1 01/29/14, 06:22

  2. Xavier Perseguers wrote 01/29/14, 07:36

    Topic set to "fal". Topic set to fal
  3. Wouter Wolters voted on patch set 1 CR +1 01/29/14, 07:43

  4. Xavier Perseguers voted on patch set 1 V +1 CR +1 01/29/14, 07:45

  5. Steffen Ritter commented on patch set 1 V +2 CR -1 01/29/14, 13:24

    commit message needs to be changed, will do today/tomorrow at the sprint and merge afterwards.
  6. Andreas Wolf updated the commit message in patch set 1 01/30/14, 12:39

  7. Andreas Wolf voted on patch set 2 V +2 CR +2 01/30/14, 12:39

  8. Andreas Wolf merged patch set 3 01/30/14, 12:39

  9. Mr. Jenkins commented on patch set 2 01/30/14, 12:53