Review main Merged

27112[BUGFIX] Add maxitems for field "metadata" in TCA

Fabien Udriot CR +2 V +2 Easy +2 −1 updated 02/02/14, 11:22

Commit message

Value "maxitems" => 1 must be added to field
`metadata` since it has a one-to-one relation.

Review

  • Code review CR +2
    • Ernesto Baschny +2
    • Wouter Wolters +1
    • Frans Saris +1
    • Ingo Schmitt +1
    • Xavier Perseguers +1
    • Stefan Froemken +1
  • Verified V +2
    • Ernesto Baschny +2

Issues 1

Files 1

Review log 13

  1. Mr. Jenkins commented on patch set 1 01/29/14, 06:35

  2. Ernesto Baschny wrote 01/29/14, 06:52

    Topic set to "fal".
  3. Wouter Wolters voted on patch set 1 CR +1 01/29/14, 07:42

  4. Xavier Perseguers voted on patch set 1 CR +1 01/29/14, 07:46

  5. Steffen Ritter commented on patch set 1 01/29/14, 13:22

    What is the benefit of that?
  6. Fabien Udriot commented on patch set 1 01/29/14, 13:28

    I use it in Media / Vidi for detecting the relation type. one-to-one relation must have their TCA define on the both sides.
  7. Frans Saris commented on patch set 1 CR +1 01/31/14, 15:29

    @Fabien how can i test this?
  8. Stefan Froemken voted on patch set 1 CR +1 01/31/14, 16:38

  9. Benni Mack commented on patch set 1 02/01/14, 09:43

    What about translations of sys-file-metadata? I have one file but 5 metadata translations...
  10. Ingo Schmitt voted on patch set 1 CR +1 02/02/14, 09:37

  11. Ernesto Baschny commented on patch set 1 V +1 CR +1 02/02/14, 11:22

    The translation is triggered by the "localize" method of the DataHandler, which doesn't check for maxitems, as it seems - because it works.
  12. Ernesto Baschny voted on patch set 1 V +2 CR +2 02/02/14, 11:22

  13. Ernesto Baschny merged patch set 2 02/02/14, 11:22